All of lore.kernel.org
 help / color / mirror / Atom feed
From: Pablo Neira <pablo@eurodev.net>
To: Anatoly Pugachev <mator@rootshell.ru>
Cc: netfilter-devel@lists.netfilter.org
Subject: Re: [PATCH pom-ng] string match on 2.6 kernel
Date: Wed, 06 Apr 2005 20:12:00 +0200	[thread overview]
Message-ID: <42542670.7010000@eurodev.net> (raw)
In-Reply-To: <20050406151645.GA3921@helminth.linuxhacker.ru>

Hi,

Anatoly Pugachev wrote:
> This kernel-2.6 patch is over cvs version of patch-o-matic, i'm used patch-o-
> matic-ng-20050316. Since i'm not a kernel programmer, this patch isn't SMP
> clean - noticed this in string/linux-2.6/info. 

Current string matching support in pom-ng has several problems:

o Boyer-Moore shifts are calculated every time a packets hits the match, 
this is not necessary. This increases the constants hidden in the O-big 
notation.
o As you pointed out, it's neither SMP nor preemptible safe. Per-cpu 
stuff is not the way to do this.

I've got a brand new infrastructure for string matching that I posted 
during xmas. As soon as I get some spare time I'll be back on it.

--
Pablo

      reply	other threads:[~2005-04-06 18:12 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-04-06 15:16 [PATCH pom-ng] string match on 2.6 kernel Anatoly Pugachev
2005-04-06 18:12 ` Pablo Neira [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=42542670.7010000@eurodev.net \
    --to=pablo@eurodev.net \
    --cc=mator@rootshell.ru \
    --cc=netfilter-devel@lists.netfilter.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.