Re: [uml-devel] Re: UML-patches to prepare UML/s390

[Bodo Stroesser <bstroesser@fujitsu-siemens.com>]

Blaisorblade wrote:
> On Wednesday 06 April 2005 20:57, Bodo Stroesser wrote:
> 
>>Jeff Dike wrote:
>>
>>>On Wed, Apr 06, 2005 at 03:27:50PM +0200, Bodo Stroesser wrote:
>>>
>>>>Here are the patches (tarball attached), that I've applied to
>>>>UML 2.6.11 + incrementals, before adding s390-files.
>>>>These patches are tested a bit on x86, but not on x86_64.
>>>
>>>I merged these, except for the restartnointr one because I don't have
>>>ERESTARTNOINTR in my /usr/include, inside a #ifdef KERNEL or not.
>>>
>>>    Jeff
>>
>>That's bad. Do you have any suggestions how to solve this?
> 
> Add it to the compilation-generated header files (the output of mk_constants, 
> mk_thread and such), so we catch it from the definition given by ourselves 
> and expose to the whole of UML.
Yeah, tx, that would be possible.
But the reason for using /usr/include/linux/errno.h was to have the host's
definition, not the one from guest.
Currently they are the same for 2.4 and 2.6, but worst case that might change in
future versions. Only debugger could note this, as ERESTART_XXXX is unvisible
to user programs.
So, when implementing your idea, maybe I should add a further test, that
our ERESTARTNOINTR *does* trigger a syscall restart on the host.

	Bodo


-------------------------------------------------------
SF email is sponsored by - The IT Product Guide
Read honest & candid reviews on hundreds of IT Products from real users.
Discover which products truly live up to the hype. Start reading now.
http://ads.osdn.com/?ad_id=6595&alloc_id=14396&op=click
_______________________________________________
User-mode-linux-devel mailing list
User-mode-linux-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/user-mode-linux-devel