From: Jeff Garzik <jgarzik@pobox.com>
To: Jay Vosburgh <fubar@us.ibm.com>
Cc: netdev@oss.sgi.com, davem@davemloft.net
Subject: Re: [PATCH 2.6.12-rc2] bonding: partially back out dev_set_mac_address
Date: Thu, 07 Apr 2005 23:50:01 -0400 [thread overview]
Message-ID: <4255FF69.4090208@pobox.com> (raw)
In-Reply-To: <200504071959.j37JxZ8g003626@death.nxdomain.ibm.com>
Jay Vosburgh wrote:
> This patch backs out some of the calls to dev_set_mac_address
> and replaces them with calls to a similar function that does not call
> notifier_call_chain.
>
> The reason for this is that the rtnetlink event handler and its
> descendents make GFP_KERNEL memory allocation requests, and the bonding
> driver makes some of its MAC address change calls from timer context
> with a lock held (notably the ALB mode).
>
> Rearranging the bonding driver to not call this way is a fairly
> involved change; this patch merely reverts one part of bonding to the
> way it used to be.
Do I need to forward this for -rc3?
Jeff
next prev parent reply other threads:[~2005-04-08 3:50 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-04-07 19:59 [PATCH 2.6.12-rc2] bonding: partially back out dev_set_mac_address Jay Vosburgh
2005-04-07 20:31 ` David S. Miller
2005-04-07 20:55 ` Jay Vosburgh
2005-04-07 20:57 ` David S. Miller
2005-04-07 21:35 ` Jay Vosburgh
2005-04-08 12:36 ` Herbert Xu
2005-04-08 20:58 ` Jay Vosburgh
2005-04-08 22:16 ` Herbert Xu
2005-04-08 23:55 ` Jay Vosburgh
2005-04-09 0:21 ` Herbert Xu
2005-04-09 0:31 ` Herbert Xu
[not found] ` <20050424185149.278ffb93.davem@davemloft.net>
2005-04-25 12:41 ` Herbert Xu
2005-04-08 3:50 ` Jeff Garzik [this message]
2005-04-08 4:45 ` David S. Miller
[not found] <20050426011907.GA13846@gondor.apana.org.au>
[not found] ` <200504260411.j3Q4BYke004030@death.nxdomain.ibm.com>
2005-04-26 11:18 ` Herbert Xu
2005-04-27 2:09 ` Jay Vosburgh
2005-04-27 2:15 ` Herbert Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4255FF69.4090208@pobox.com \
--to=jgarzik@pobox.com \
--cc=davem@davemloft.net \
--cc=fubar@us.ibm.com \
--cc=netdev@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.