All of lore.kernel.org
 help / color / mirror / Atom feed
From: Paul Eggleton <paul.eggleton@linux.intel.com>
To: "Robert P. J. Day" <rpjday@crashcourse.ca>
Cc: openembedded-core@lists.openembedded.org
Subject: Re: proper use of CORE_IMAGE_EXTRA_INSTALL?
Date: Tue, 19 Jun 2012 18:44:06 +0100	[thread overview]
Message-ID: <4256903.kAPMsSF2tk@helios> (raw)
In-Reply-To: <alpine.DEB.2.02.1206191257390.1069@oneiric>

On Tuesday 19 June 2012 13:05:35 Robert P. J. Day wrote:
>   followup to earlier post, it's easy enough to see the point of this
> code from core-image.bbclass:
> 
> ... snip ...
> 
> CORE_IMAGE_BASE_INSTALL = '\
>     task-core-boot \
>     task-base-extended \
>     \
>     ${CORE_IMAGE_EXTRA_INSTALL} \
>     '
> 
> CORE_IMAGE_EXTRA_INSTALL ?= ""
> 
> IMAGE_INSTALL ?= "${CORE_IMAGE_BASE_INSTALL}"
> 
> ... snip ...
> 
>   but i can see this snippet from
> meta/recipes-graphics/images/core-image-gtk-directfb.bb:
> 
> ... snip ...
> 
> inherit core-image
> 
> IMAGE_INSTALL += "\
>         ${CORE_IMAGE_BASE_INSTALL} \
>         task-core-basic \
>         task-core-gtk-directfb-base \
> "
> 
> ... snip ...
> 
>   now this would seem to be exactly what the variable
> CORE_IMAGE_EXTRA_INSTALL was invented for, no?  certainly the above
> will work but then what's the point of having
> CORE_IMAGE_EXTRA_INSTALL?
> 
>   however, if one used that, it's obvious that one would leave the
> line "inherit core-image" to near the bottom of the .bb file, but
> returning to my earlier question, what is the proper ordering of
> setting CORE_IMAGE_EXTRA_INSTALL and inheriting core-image.  it's
> clear "inherit core-image" would always work *after*, but what about
> before?

I feel like we've gone over this ground quite a lot; but I guess that's 
because our documentation and examples still aren't clear, so fair enough.

There's nothing forcing you into a specific usage here, however we might make 
some recommendations. My recommendation would be to leave 
CORE_IMAGE_EXTRA_INSTALL for use from local.conf - i.e. don't use it in your 
own image recipe; if you want to add things there use IMAGE_INSTALL += or 
IMAGE_INSTALL_append (see other thread).

Cheers,
Paul

-- 

Paul Eggleton
Intel Open Source Technology Centre



  reply	other threads:[~2012-06-19 17:54 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-06-19 17:05 proper use of CORE_IMAGE_EXTRA_INSTALL? Robert P. J. Day
2012-06-19 17:44 ` Paul Eggleton [this message]
2012-06-19 17:52   ` Robert P. J. Day

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4256903.kAPMsSF2tk@helios \
    --to=paul.eggleton@linux.intel.com \
    --cc=openembedded-core@lists.openembedded.org \
    --cc=rpjday@crashcourse.ca \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.