From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH v2] nfp: report link speed using hardware info Date: Mon, 21 Nov 2016 10:22:15 +0100 Message-ID: <4259357.KtzkFjZByE@xps13> References: <1479485218-11931-1-git-send-email-alejandro.lucero@netronome.com> <1901770.8floaBijqc@xps13> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: dev@dpdk.org To: Alejandro Lucero Return-path: Received: from mail-wm0-f47.google.com (mail-wm0-f47.google.com [74.125.82.47]) by dpdk.org (Postfix) with ESMTP id 6B1D75583 for ; Mon, 21 Nov 2016 14:04:56 +0100 (CET) Received: by mail-wm0-f47.google.com with SMTP id g23so145898125wme.1 for ; Mon, 21 Nov 2016 05:04:56 -0800 (PST) In-Reply-To: List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 2016-11-18 16:50, Alejandro Lucero: > On Fri, Nov 18, 2016 at 4:29 PM, Thomas Monjalon > wrote: > > You should update the doc in the same patch: > > doc/guides/nics/features/nfp.ini > > It will be the first feature as the file appears to be empty. > > So you will need another patch to fill other existing features. > > > > Yes. I'm just working on updating that file properly. > May I delay this doc change for including it with that other one? > It will be a bit weird to just have one feature there. It will provide you a good motivation to fix the doc :) Up to you