From: "H. Peter Anvin" <hpa@zytor.com>
To: jayalk@intworks.biz
Cc: linux-kernel@vger.kernel.org, davej@codemonkey.org.uk
Subject: Re: [PATCH 2.6.11.7 1/1] x86 reboot: Add reboot fixup for gx1/cs5530a
Date: Mon, 11 Apr 2005 05:16:33 -0700 [thread overview]
Message-ID: <425A6AA1.3050601@zytor.com> (raw)
In-Reply-To: <200504110702.j3B72hau000852@intworks.biz>
jayalk@intworks.biz wrote:
> Hi Riley, Dave, Peter, i386 boot/workaround maintainers,
>
> I'm resending this patch (from March 28).
>
> This patch incorporates the suggestions from the previous thread and also
> switches to using pci_get_device since pci_find_device is deprecated, and
> made some of the variables static.
>
> Please let me know if it's okay.
>
> +#define mach_reboot_fixups(x) do {} while (0)
As I stated last time, this should be:
#define mach_reboot_fixup(x) ((void)(x))
... to preserve side effects, and be expression-like.
-hpa
next prev parent reply other threads:[~2005-04-11 12:16 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-04-11 7:02 [PATCH 2.6.11.7 1/1] x86 reboot: Add reboot fixup for gx1/cs5530a jayalk
2005-04-11 12:16 ` H. Peter Anvin [this message]
2005-04-11 12:38 ` Richard B. Johnson
2005-04-11 13:29 ` H. Peter Anvin
-- strict thread matches above, loose matches on Subject: below --
2005-04-12 1:18 jayalk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=425A6AA1.3050601@zytor.com \
--to=hpa@zytor.com \
--cc=davej@codemonkey.org.uk \
--cc=jayalk@intworks.biz \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.