From: Thomas Monjalon <thomas.monjalon-pdR9zngts4EAvxtiuMwx3w@public.gmane.org>
To: Matthew Hall <mhall-Hv3ogNYU3JfZZajBQzqCxQ@public.gmane.org>
Cc: dev-VfR2kkLFssw@public.gmane.org
Subject: Re: [PATCH 2/4] virtio-net.c: incorrect parens around equality check
Date: Tue, 22 Jul 2014 15:14:51 +0200 [thread overview]
Message-ID: <42607666.SQuAkzsMo0@xps13> (raw)
In-Reply-To: <1405914461-19335-3-git-send-email-mhall-Hv3ogNYU3JfZZajBQzqCxQ@public.gmane.org>
Hi Matthew,
I think that patches 1, 3 and 4 need some rework but this one is valid
and has no relation with other ones in the serie. So it can be integrated now.
2014-07-20 20:47, Matthew Hall:
> --- a/examples/vhost/virtio-net.c
> +++ b/examples/vhost/virtio-net.c
> @@ -280,8 +280,8 @@ get_config_ll_entry(struct vhost_device_ctx ctx)
>
> /* Loop through linked list until the device_fh is found. */
> while (ll_dev != NULL) {
> - if ((ll_dev->dev.device_fh == ctx.fh))
> - return ll_dev;
> + if (ll_dev->dev.device_fh == ctx.fh)
> + return ll_dev;
> ll_dev = ll_dev->next;
> }
Acked-by: Thomas Monjalon <thomas.monjalon-pdR9zngts4EAvxtiuMwx3w@public.gmane.org>
Applied for version 1.7.1.
Thanks
--
Thomas
next prev parent reply other threads:[~2014-07-22 13:14 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-21 3:47 [PATCH] examples: fix clang compilation issues Matthew Hall
[not found] ` <1405914461-19335-1-git-send-email-mhall-Hv3ogNYU3JfZZajBQzqCxQ@public.gmane.org>
2014-07-21 3:47 ` [PATCH 1/4] l3fwd: some functions are unused in l3fwd-acl Matthew Hall
[not found] ` <1405914461-19335-2-git-send-email-mhall-Hv3ogNYU3JfZZajBQzqCxQ@public.gmane.org>
2014-07-21 13:44 ` Thomas Monjalon
2014-07-21 16:53 ` Matthew Hall
2014-07-21 17:37 ` Richardson, Bruce
2014-07-21 3:47 ` [PATCH 2/4] virtio-net.c: incorrect parens around equality check Matthew Hall
[not found] ` <1405914461-19335-3-git-send-email-mhall-Hv3ogNYU3JfZZajBQzqCxQ@public.gmane.org>
2014-07-22 13:14 ` Thomas Monjalon [this message]
2014-07-22 19:27 ` Matthew Hall
2014-07-21 3:47 ` [PATCH 3/4] examples/*: -Wno-switch required for weird ioctl() ID's Matthew Hall
[not found] ` <1405914461-19335-4-git-send-email-mhall-Hv3ogNYU3JfZZajBQzqCxQ@public.gmane.org>
2014-07-21 13:45 ` Thomas Monjalon
2014-07-21 3:47 ` [PATCH 4/4] rte.extvars.mk: allow user to override RTE_SDK_BIN Matthew Hall
[not found] ` <1405914461-19335-5-git-send-email-mhall-Hv3ogNYU3JfZZajBQzqCxQ@public.gmane.org>
2014-07-21 14:31 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=42607666.SQuAkzsMo0@xps13 \
--to=thomas.monjalon-pdr9zngts4eavxtiumwx3w@public.gmane.org \
--cc=dev-VfR2kkLFssw@public.gmane.org \
--cc=mhall-Hv3ogNYU3JfZZajBQzqCxQ@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.