struct nf_sockopt_ops

[Carl-Daniel Hailfinger <c-d.hailfinger.devel.2005@gmx.net>]

Forgive me if that has already been discussed.

I'm wondering why the get and set members of the struct take
some form of int as last parameter. Wouldn't be a long be the
more logical choice? I can see changing the type here wouldn't
help because nf_sockopt also accepting only an int for len.

struct nf_sockopt_ops
{
/* snip */
        int (*set)(struct sock *sk, int optval, void __user *user, unsigned int len);
/* snip */
        int (*get)(struct sock *sk, int optval, void __user *user, int *len);
/* snip */
};

Or at least the last parameter of the set member being a
signed int to match the parameter to nf_sockopt.

Any insight into why the parameters were chosen that way
would be truly appreciated.


Regards,
Carl-Daniel