From: Fabrice Bellard <fabrice@bellard.org>
To: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] compiler error in CONFIG_S3VGA
Date: Sun, 17 Apr 2005 21:31:32 +0200 [thread overview]
Message-ID: <4262B994.6010807@bellard.org> (raw)
In-Reply-To: <20050417185200.GF15688@aon.at>
In fact the real fix is to delete the S3VGA stuff - it has never worked
and I have no plan to support it. Moveover, a correct implementation
would be made in another driver as the cirrus_vga driver.
Fabrice.
Bernhard Fischer wrote:
> Hi,
>
> qemu/hw/vga.c: typo: s/uinr32_t/uint32_t/
>
> Thank you,
>
>
> ------------------------------------------------------------------------
>
> diff -X excl -rduNp qemu.oorig/hw/vga.c qemu/hw/vga.c
> --- qemu.oorig/hw/vga.c 2005-02-10 23:00:27.000000000 +0100
> +++ qemu/hw/vga.c 2005-04-17 02:47:10.000000000 +0200
> @@ -956,7 +956,7 @@ static void vga_get_offsets(VGAState *s,
> line_offset = s->cr[0x13];
> #ifdef CONFIG_S3VGA
> {
> - uinr32_t v;
> + uint32_t v;
> v = (s->cr[0x51] >> 4) & 3; /* S3 extension */
> if (v == 0)
> v = (s->cr[0x43] >> 2) & 1; /* S3 extension */
>
>
>
> ------------------------------------------------------------------------
>
> _______________________________________________
> Qemu-devel mailing list
> Qemu-devel@nongnu.org
> http://lists.nongnu.org/mailman/listinfo/qemu-devel
next prev parent reply other threads:[~2005-04-17 19:32 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-04-17 18:52 [Qemu-devel] compiler error in CONFIG_S3VGA Bernhard Fischer
2005-04-17 19:31 ` Fabrice Bellard [this message]
2005-04-17 21:01 ` Bernhard Fischer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4262B994.6010807@bellard.org \
--to=fabrice@bellard.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.