From: Jens Axboe <axboe@fb.com>
To: Bart Van Assche <Bart.VanAssche@sandisk.com>
Cc: Omar Sandoval <osandov@fb.com>, Hannes Reinecke <hare@suse.de>,
"linux-block@vger.kernel.org" <linux-block@vger.kernel.org>
Subject: Re: [PATCH] blk-mq: Export queue state through /sys/kernel/debug/block/*/state
Date: Wed, 29 Mar 2017 14:31:01 -0600 [thread overview]
Message-ID: <42634489-db2d-e04d-28ba-3943a185a678@fb.com> (raw)
In-Reply-To: <1D08B61A9CF0974AA09887BE32D889DA12B851@ULS-OP-MBXIP03.sdcorp.global.sandisk.com>
On 03/29/2017 02:20 PM, Bart Van Assche wrote:
> Make it possible to check whether or not a block layer queue has
> been stopped. Make it possible to run a blk-mq queue from user
> space.
I like this, I've had run-this-queue wired up as well from sysfs
in the past. Maybe we should push it one further, and also allow
things like running a stopped queue?
Would probably be nicer if the file accepted input like "run" (which
would be your current run-this-queue) and "start" (start stopped
queues).
Then we could also EINVAL writes that we don't grok, instead of
just blindly always running the queue.
--
Jens Axboe
next prev parent reply other threads:[~2017-03-29 20:31 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-29 20:20 [PATCH] blk-mq: Export queue state through /sys/kernel/debug/block/*/state Bart Van Assche
2017-03-29 20:31 ` Jens Axboe [this message]
2017-03-30 5:50 ` Hannes Reinecke
2017-03-30 15:16 ` Bart Van Assche
2017-03-30 15:19 ` Jens Axboe
2017-03-30 15:23 ` Bart Van Assche
-- strict thread matches above, loose matches on Subject: below --
2017-03-29 21:32 Bart Van Assche
2017-03-30 15:27 ` Jens Axboe
2017-03-30 18:10 ` Bart Van Assche
2017-03-30 18:14 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=42634489-db2d-e04d-28ba-3943a185a678@fb.com \
--to=axboe@fb.com \
--cc=Bart.VanAssche@sandisk.com \
--cc=hare@suse.de \
--cc=linux-block@vger.kernel.org \
--cc=osandov@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.