From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: whittenburg@gmail.com
Cc: Sakari Ailus <sakari.ailus@iki.fi>, linux-media@vger.kernel.org
Subject: Re: OMAP3 ISP previewer Y10 to UYVY conversion
Date: Wed, 08 Apr 2015 13:17:13 +0300 [thread overview]
Message-ID: <4266372.QbGlLsYjom@avalon> (raw)
In-Reply-To: <CABcw_OkPa_xuN_R5B3PfVWcVKxVXFRCJS4xEvaGbCH=Vvdhbgg@mail.gmail.com>
Hi Chris,
On Tuesday 07 April 2015 11:45:10 Chris Whittenburg wrote:
> On Tue, Apr 7, 2015 at 10:51 AM, Laurent Pinchart wrote:
> > I suspect the RGB2RGB conversion matrix to be wrong. The default setting
> > is supposed to handle fluorescent lighting. You could try setting the
> > RGB2RGB matrix to the identity matrix and see if this helps. See
> > http://git.ideasonboard.org/omap3-isp-live.git/blob/HEAD:/isp/controls.c#l
> > 184 for sample code.
> >
> > Another matrix that could be worth being reprogrammed is the RGB2YUV
> > matrix, which also defaults to fluorescent lighting. Sample code to
> > reprogram it is available in the same location.
>
> Thanks Laurent...
>
> Just to verify, the conversion matrix still plays a role even though
> the input format is Y10?
Yes it does. The preview engine first converts Y10 to RGB by duplicating the Y
value for all three channels, then feeds it through the RGB2RGB matrix, the
gamma table, and the RGB2YUV matrix.
--
Regards,
Laurent Pinchart
next prev parent reply other threads:[~2015-04-08 10:16 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-18 19:56 OMAP3 ISP previewer Y10 to UYVY conversion Chris Whittenburg
2015-03-24 23:51 ` Sakari Ailus
2015-03-25 14:12 ` Chris Whittenburg
2015-03-25 23:58 ` Sakari Ailus
2015-04-07 15:51 ` Laurent Pinchart
2015-04-07 16:45 ` Chris Whittenburg
2015-04-08 10:17 ` Laurent Pinchart [this message]
2015-04-16 18:05 ` Chris Whittenburg
2015-04-17 9:39 ` Laurent Pinchart
2015-04-21 16:04 ` Chris Whittenburg
2015-04-21 16:16 ` Laurent Pinchart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4266372.QbGlLsYjom@avalon \
--to=laurent.pinchart@ideasonboard.com \
--cc=linux-media@vger.kernel.org \
--cc=sakari.ailus@iki.fi \
--cc=whittenburg@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.