From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.dev.rtsoft.ru (RT-soft-2.Moscow.itn.ru [80.240.96.70]) by ozlabs.org (Postfix) with SMTP id B49D967A6B for ; Thu, 21 Apr 2005 22:04:28 +1000 (EST) Message-ID: <426796C7.3090501@ru.mvista.com> Date: Thu, 21 Apr 2005 16:04:23 +0400 From: Vitaly Bordug MIME-Version: 1.0 To: Kumar Gala , linuxppc-embedded@ozlabs.org References: <425D35E0.4040305@nm.ru> <425D5885.2040605@ru.mvista.com> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Subject: Re: [PATCH 2.6.12-rc2] Freescale 8272ADS PCI bridge support to the stock linux-2.5 (updated) List-Id: Linux on Embedded PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Kumar Gala wrote: >On Wed, 13 Apr 2005, Vitaly Bordug wrote: > >Finally, had some time to really look at this patch, comments are inline. >Look for (galak). A few high level comments: > >Can we fold pq2ads_setup_hose into pq2ads_setup_pci? > No problem, I think... > Also, is there >anything to be done to unify m8260_setup_pci & >pq2ads_setup_pci.. > Well, in my opinion, m8260_setup_pci should be replaced with pq2ads_setup_pci, as far as they are intended to do the same (as I mentioned in my very first PCI patch marked as RFC). But I actually cannot test this stuff on anything other than 8272ads, so this way I'm trying not to break existing code. The latter, BTW, currently has limited functionality and I _guess_ I will not break anything if only pq2ads_setup_pci remain. What do you think? Other issues will be fixed shortly. Thanks. -- Sincerely, Vitaly