Re: [PATCH mptcp-next v3 0/7] add fastclose testcases

[Mat Martineau <mathew.j.martineau@linux.intel.com>]

[-- Attachment #1: Type: text/plain, Size: 2005 bytes --]

On Tue, 15 Feb 2022, Geliang Tang wrote:

> v3:
> - merge the squash-to patch ("Squash to "selftests: mptcp: add
> fastclose testcases v2") into v3.
> - add a new patch to check fastclose in mptcp_connect.sh
>
> base-commit: 9dff76d953f7a0fe2b27818f2aa93031c9a617cf
>
> v2:
> - merge the squash-to patch ("Squash to "selftests: mptcp: add the
> MP_RST mibs check") into v2.
> - update the commit logs.
>
> This patchset is related to issue #48 and issue #197. The two MP_RST
> patches are moved from the "add mp_fail testcases" series.
>

Hi Geliang -

The code changes and the squash-to patch look good in terms of code 
review. When I run the 'mptcp_join.sh -z' test I get intermittent failures 
with "fastclose test 2":

002 fastclose test 2                     syn[ ok ] - synack[ ok ] - ack[ ok ]
                                          ctx[ ok ] - fclzrx[fail] got 1 MP_FASTCLOSE[s] RX expected 2
                                          rtx[ ok ] - rstrx [fail] got 1 MP_RST[s] RX expected 2   invert

(removed MIB dump)

I was able to reproduce while capturing, and the capture in the failed 
test does have 2 MP_FASTCLOSE and 2 MP_RST. Maybe there's a timing issue 
reading the MIBs?

I attached the pcaps, one for passing and one for failing.

-Mat


> Geliang Tang (7):
>  mptcp: add the mibs for MP_FASTCLOSE
>  selftests: mptcp: add the MP_FASTCLOSE mibs check
>  mptcp: add the mibs for MP_RST
>  selftests: mptcp: add the MP_RST mibs check
>  selftests: mptcp: add extra_args in do_transfer
>  selftests: mptcp: add fastclose testcases
>  selftests: mptcp: fastclose check in mptcp_connect
>
> net/mptcp/mib.c                               |   4 +
> net/mptcp/mib.h                               |   4 +
> net/mptcp/options.c                           |   5 +
> .../selftests/net/mptcp/mptcp_connect.sh      |  37 +++++
> .../testing/selftests/net/mptcp/mptcp_join.sh | 134 ++++++++++++++++--
> 5 files changed, 171 insertions(+), 13 deletions(-)
>
> -- 
> 2.34.1

--
Mat Martineau
Intel

[-- Attachment #2: Type: application/octet-stream, Size: 13231 bytes --]