From mboxrd@z Thu Jan 1 00:00:00 1970 From: Laurent Pinchart Subject: Re: [PATCH] drm/bridge: analogix-anx78xx: Switch to SPDX identifier. Date: Tue, 05 Jun 2018 13:33:49 +0300 Message-ID: <4268268.FVg14MziXp@avalon> References: <20180605100051.4023-1-enric.balletbo@collabora.com> <1896069.8N7yzJMC7C@avalon> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) by gabe.freedesktop.org (Postfix) with ESMTPS id DC86B8997A for ; Tue, 5 Jun 2018 10:33:40 +0000 (UTC) In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Enric Balletbo i Serra Cc: David Airlie , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, kernel@collabora.com List-Id: dri-devel@lists.freedesktop.org SGkgRW5yaWMsCgpPbiBUdWVzZGF5LCA1IEp1bmUgMjAxOCAxMzoyNzowNiBFRVNUIEVucmljIEJh bGxldGJvIGkgU2VycmEgd3JvdGU6Cj4gT24gMDUvMDYvMTggMTI6MTEsIExhdXJlbnQgUGluY2hh cnQgd3JvdGU6Cj4gPiBPbiBUdWVzZGF5LCA1IEp1bmUgMjAxOCAxMzowMDo1MCBFRVNUIEVucmlj IEJhbGxldGJvIGkgU2VycmEgd3JvdGU6Cj4gPj4gQWRvcHQgdGhlIFNQRFggbGljZW5zZSBpZGVu dGlmaWVyIGhlYWRlcnMgdG8gZWFzZSBsaWNlbnNlIGNvbXBsaWFuY2UKPiA+PiBtYW5hZ2VtZW50 Lgo+ID4+IAo+ID4+IFNpZ25lZC1vZmYtYnk6IEVucmljIEJhbGxldGJvIGkgU2VycmEgPGVucmlj LmJhbGxldGJvQGNvbGxhYm9yYS5jb20+Cj4gPj4gLS0tCj4gPj4gCj4gPj4gIGRyaXZlcnMvZ3B1 L2RybS9icmlkZ2UvYW5hbG9naXgtYW54Nzh4eC5jIHwgMjQgKysrKysrKystLS0tLS0tLS0tLS0t LS0KPiA+PiAgMSBmaWxlIGNoYW5nZWQsIDggaW5zZXJ0aW9ucygrKSwgMTYgZGVsZXRpb25zKC0p Cj4gPj4gCj4gPj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9icmlkZ2UvYW5hbG9naXgt YW54Nzh4eC5jCj4gPj4gYi9kcml2ZXJzL2dwdS9kcm0vYnJpZGdlL2FuYWxvZ2l4LWFueDc4eHgu YyBpbmRleAo+ID4+IGI0OTA0Mzg2NmJlNi4uNTRkN2U3OTgxYmVkIDEwMDY0NAo+ID4+IC0tLSBh L2RyaXZlcnMvZ3B1L2RybS9icmlkZ2UvYW5hbG9naXgtYW54Nzh4eC5jCj4gPj4gKysrIGIvZHJp dmVycy9ncHUvZHJtL2JyaWRnZS9hbmFsb2dpeC1hbng3OHh4LmMKPiA+PiBAQCAtMSwxOSArMSwx MSBAQAo+ID4+IC0vKgo+ID4+IC0gKiBDb3B5cmlnaHQoYykgMjAxNiwgQW5hbG9naXggU2VtaWNv bmR1Y3Rvci4KPiA+PiAtICoKPiA+PiAtICogVGhpcyBwcm9ncmFtIGlzIGZyZWUgc29mdHdhcmU7 IHlvdSBjYW4gcmVkaXN0cmlidXRlIGl0IGFuZC9vciBtb2RpZnkKPiA+PiAtICogaXQgdW5kZXIg dGhlIHRlcm1zIG9mIHRoZSBHTlUgR2VuZXJhbCBQdWJsaWMgTGljZW5zZSB2ZXJzaW9uIDIgYW5k Cj4gPj4gLSAqIG9ubHkgdmVyc2lvbiAyIGFzIHB1Ymxpc2hlZCBieSB0aGUgRnJlZSBTb2Z0d2Fy ZSBGb3VuZGF0aW9uLgo+ID4+IC0gKgo+ID4+IC0gKiBUaGlzIHByb2dyYW0gaXMgZGlzdHJpYnV0 ZWQgaW4gdGhlIGhvcGUgdGhhdCBpdCB3aWxsIGJlIHVzZWZ1bCwKPiA+PiAtICogYnV0IFdJVEhP VVQgQU5ZIFdBUlJBTlRZOyB3aXRob3V0IGV2ZW4gdGhlIGltcGxpZWQgd2FycmFudHkgb2YKPiA+ PiAtICogTUVSQ0hBTlRBQklMSVRZIG9yIEZJVE5FU1MgRk9SIEEgUEFSVElDVUxBUiBQVVJQT1NF LiAgU2VlIHRoZQo+ID4+IC0gKiBHTlUgR2VuZXJhbCBQdWJsaWMgTGljZW5zZSBmb3IgbW9yZSBk ZXRhaWxzLgo+ID4+IC0gKgo+ID4+IC0gKiBCYXNlZCBvbiBhbng3ODA4IGRyaXZlciBvYnRhaW5l ZCBmcm9tIGNocm9tZW9zIHdpdGggY29weXJpZ2h0Ogo+ID4+IC0gKiBDb3B5cmlnaHQoYykgMjAx MywgR29vZ2xlIEluYy4KPiA+PiAtICoKPiA+PiAtICovCj4gPj4gKy8vIFNQRFgtTGljZW5zZS1J ZGVudGlmaWVyOiBHUEwtMi4wCj4gPiAKPiA+IFRoaXMgbG9va3MgZ29vZCB0byBtLgo+ID4gCj4g Pj4gKy8vIERyaXZlciBmb3IgQU5YNzh4eCBTbGltUG9ydCB0cmFuc21pdHRlci4KPiA+PiArLy8K PiA+PiArLy8gQ29weXJpZ2h0IChDKSAyMDE2IEFuYWxvZ2l4IFNlbWljb25kdWN0b3IuCj4gPj4g Ky8vIENvcHlyaWdodCAoQykgMjAxNiBHb29nbGUsIEluYy4KPiA+IAo+ID4gU2hvdWxkIHRoZSBs YXN0IGxpbmUgYmUgMjAxMywgbm90IDIwMTYgPwo+IAo+IFllcywgbXkgYmFkLgo+IAo+ID4+ICsv Lwo+ID4+ICsvLyBBdXRob3I6IEVucmljIEJhbGxldGJvIGkgU2VycmEgPGVucmljLmJhbGxldGJv QGNvbGxhYm9yYS5jb20+Cj4gPiAKPiA+IEkgZG9uJ3QgdGhpbmsgdGhlcmUncyBhIG5lZWQgdG8g Y29udmVydCB0aGUgd2hvbGUgY29tbWVudCBibG9jayB0bwo+ID4gQysrLXN0eWxlLgo+IAo+IFNl ZW1zIHRoYXQgcHV0dGluZyBldmVyeXRoaW5nIGFzIC8vIGlzIExpbnVzIFRvcnZhbGRzJyBwcmVm ZXJyZWQgc3R5bGU6Cj4gaHR0cHM6Ly9sa21sLm9yZy9sa21sLzIwMTcvMTEvMjUvMTMzCj4gCj4g QnV0IGlmIHlvdSB3YW50IEkgY2hhbmdlLCBJIGRvbid0IG1pbmQgdG8gdXNlIHRoZSBjIHN0eWxl IGluc3RlYWQsIGp1c3QgbGV0Cj4gbWUga25vdy4KCkFzIHVzdWFsIHdpdGggY29kaW5nIHN0eWxl cywgaXQncyBhIG1hdHRlciBvZiBwcmVmZXJlbmNlcywgZmVlbGluZ3MsIGFuZCAKZ2V0dGluZyB1 c2VkIHRvIGNoYW5nZXMuIEkgcGVyc29uYWxseSBkaXNsaWtlIEMrKy1zdHlsZSBjb21tZW50cyBp biBrZXJuZWwgCnNvdXJjZXMuIFRoZSBmYWN0IHRoYXQgd2UgaGF2ZSBmZXcgb2YgdGhlbSBtYWtl cyB0aGVtIHNlZW0gb3V0IG9mIHBsYWNlLCBhbmQgCnRodXMgZGlzdHVyYiBjb2RlIHJlYWRpbmcu IE15IHByZWZlcmVuY2VzIG1pZ2h0IGNoYW5nZSBpZiB0aGUgc3R5bGUgYmVjb21lcyAKbW9yZSBw cm9taW5lbnQgYW5kIEkgZ2V0IHVzZWQgdG8gaXQuIE9yIG1heWJlIG5vdCA6LSkKClRoaXMgYmVp bmcgc2FpZCwgSSdkIHBlcnNvbmFsbHkga2VlcCBjaGFuZ2VzIG1pbmltYWwgaGVyZSwgYW5kIGdp dmUgdGhlIGxhc3QgCndvcmQgdG8gdGhlIGRyaXZlciBtYWludGFpbmVyKHMpIGFzIGZvciBhbnkg Y29kaW5nIHN0eWxlIG1hdHRlci4KCj4gPj4gICNpbmNsdWRlIDxsaW51eC9kZWxheS5oPgo+ID4+ ICAjaW5jbHVkZSA8bGludXgvZXJyLmg+Cj4gPj4gICNpbmNsdWRlIDxsaW51eC9pbnRlcnJ1cHQu aD4KCi0tIApSZWdhcmRzLAoKTGF1cmVudCBQaW5jaGFydAoKCgpfX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fXwpkcmktZGV2ZWwgbWFpbGluZyBsaXN0CmRyaS1k ZXZlbEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcv bWFpbG1hbi9saXN0aW5mby9kcmktZGV2ZWwK From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751819AbeFEKdo (ORCPT ); Tue, 5 Jun 2018 06:33:44 -0400 Received: from perceval.ideasonboard.com ([213.167.242.64]:35840 "EHLO perceval.ideasonboard.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751696AbeFEKdj (ORCPT ); Tue, 5 Jun 2018 06:33:39 -0400 From: Laurent Pinchart To: Enric Balletbo i Serra Cc: linux-kernel@vger.kernel.org, kernel@collabora.com, Andrzej Hajda , Archit Taneja , dri-devel@lists.freedesktop.org, David Airlie Subject: Re: [PATCH] drm/bridge: analogix-anx78xx: Switch to SPDX identifier. Date: Tue, 05 Jun 2018 13:33:49 +0300 Message-ID: <4268268.FVg14MziXp@avalon> Organization: Ideas on Board Oy In-Reply-To: References: <20180605100051.4023-1-enric.balletbo@collabora.com> <1896069.8N7yzJMC7C@avalon> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Enric, On Tuesday, 5 June 2018 13:27:06 EEST Enric Balletbo i Serra wrote: > On 05/06/18 12:11, Laurent Pinchart wrote: > > On Tuesday, 5 June 2018 13:00:50 EEST Enric Balletbo i Serra wrote: > >> Adopt the SPDX license identifier headers to ease license compliance > >> management. > >> > >> Signed-off-by: Enric Balletbo i Serra > >> --- > >> > >> drivers/gpu/drm/bridge/analogix-anx78xx.c | 24 ++++++++--------------- > >> 1 file changed, 8 insertions(+), 16 deletions(-) > >> > >> diff --git a/drivers/gpu/drm/bridge/analogix-anx78xx.c > >> b/drivers/gpu/drm/bridge/analogix-anx78xx.c index > >> b49043866be6..54d7e7981bed 100644 > >> --- a/drivers/gpu/drm/bridge/analogix-anx78xx.c > >> +++ b/drivers/gpu/drm/bridge/analogix-anx78xx.c > >> @@ -1,19 +1,11 @@ > >> -/* > >> - * Copyright(c) 2016, Analogix Semiconductor. > >> - * > >> - * This program is free software; you can redistribute it and/or modify > >> - * it under the terms of the GNU General Public License version 2 and > >> - * only version 2 as published by the Free Software Foundation. > >> - * > >> - * This program is distributed in the hope that it will be useful, > >> - * but WITHOUT ANY WARRANTY; without even the implied warranty of > >> - * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the > >> - * GNU General Public License for more details. > >> - * > >> - * Based on anx7808 driver obtained from chromeos with copyright: > >> - * Copyright(c) 2013, Google Inc. > >> - * > >> - */ > >> +// SPDX-License-Identifier: GPL-2.0 > > > > This looks good to m. > > > >> +// Driver for ANX78xx SlimPort transmitter. > >> +// > >> +// Copyright (C) 2016 Analogix Semiconductor. > >> +// Copyright (C) 2016 Google, Inc. > > > > Should the last line be 2013, not 2016 ? > > Yes, my bad. > > >> +// > >> +// Author: Enric Balletbo i Serra > > > > I don't think there's a need to convert the whole comment block to > > C++-style. > > Seems that putting everything as // is Linus Torvalds' preferred style: > https://lkml.org/lkml/2017/11/25/133 > > But if you want I change, I don't mind to use the c style instead, just let > me know. As usual with coding styles, it's a matter of preferences, feelings, and getting used to changes. I personally dislike C++-style comments in kernel sources. The fact that we have few of them makes them seem out of place, and thus disturb code reading. My preferences might change if the style becomes more prominent and I get used to it. Or maybe not :-) This being said, I'd personally keep changes minimal here, and give the last word to the driver maintainer(s) as for any coding style matter. > >> #include > >> #include > >> #include -- Regards, Laurent Pinchart