From: Patrick McHardy <kaber@trash.net>
To: Stephen Hemminger <shemminger@osdl.org>
Cc: "David S. Miller" <davem@davemloft.net>, netdev@oss.sgi.com
Subject: Re: [PATCH] netem: account for packets in delayed queue in qlen
Date: Fri, 22 Apr 2005 01:10:25 +0200 [thread overview]
Message-ID: <426832E1.7020003@trash.net> (raw)
In-Reply-To: <20050421132020.41858bc4@localhost.localdomain>
Stephen Hemminger wrote:
> So duplication is a no go...
> Unless there is a different way of accounting for qlen (like a callback).
Instead of a callback you could store parent pointers in struct Qdisc
and walk up the tree. One place that would need additional changes to
cope with qlen changes of more than 1 is HFSC. It uses q.qlen == 1 as
indication that a leaf qdisc was activated by the last enqueue
operation. An increment of 2 when q.qlen was 0 before would cause HFSC
to forget to activate a class.
Regards
Patrick
next prev parent reply other threads:[~2005-04-21 23:10 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-03-29 23:21 [PATCH] netem: account for packets in delayed queue in qlen Stephen Hemminger
2005-04-01 4:36 ` David S. Miller
2005-04-05 19:48 ` Patrick McHardy
2005-04-05 19:58 ` Stephen Hemminger
2005-04-07 19:04 ` Stephen Hemminger
2005-04-17 15:38 ` Patrick McHardy
2005-04-19 1:06 ` Stephen Hemminger
2005-04-20 14:00 ` Patrick McHardy
2005-04-21 3:20 ` Stephen Hemminger
2005-04-21 23:10 ` Patrick McHardy [this message]
2005-04-21 23:22 ` Stephen Hemminger
2005-04-21 23:39 ` Patrick McHardy
2005-04-22 0:05 ` jamal
2005-04-22 0:10 ` Patrick McHardy
2005-04-22 0:32 ` jamal
2005-04-22 0:40 ` jamal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=426832E1.7020003@trash.net \
--to=kaber@trash.net \
--cc=davem@davemloft.net \
--cc=netdev@oss.sgi.com \
--cc=shemminger@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.