From: Krzysztof Kozlowski <krzk@kernel.org>
To: Andreas Klinger <ak@it-klinger.de>, Jonathan Cameron <jic23@kernel.org>
Cc: robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org,
lars@metafoo.de, linux-iio@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
javier.carrasco.cruz@gmail.com, mazziesaccount@gmail.com,
subhajit.ghosh@tweaklogic.com, muditsharma.info@gmail.com,
arthur.becker@sentec.com, ivan.orlov0322@gmail.com
Subject: Re: [PATCH 1/3] dt-bindings: iio: light: veml6046x00: add color sensor
Date: Mon, 17 Mar 2025 12:26:04 +0100 [thread overview]
Message-ID: <42685f01-d864-4e68-913a-49bdb6337581@kernel.org> (raw)
In-Reply-To: <Z9gEveqC91o8Ojks@mail.your-server.de>
On 17/03/2025 12:17, Andreas Klinger wrote:
>>> + - |
>>> + i2c {
>>> + #address-cells = <1>;
>>> + #size-cells = <0>;
>>> +
>>> + color-sensor@29 {
>>> + compatible = "vishay,veml6046x00";
>>> + reg = <0x29>;
>>> + vdd-supply = <&vdd_reg>;
>>> + interrupt-parent = <&gpio2>;
>>> + interrupts = <3 IRQ_TYPE_EDGE_FALLING>;
>> Need an include for this I think. Make sure to test build your
>> bindings following the instructions in the bot message.
>
> I already sent out an version 2 yesterday which is with the include, tested and
> already reviewed by Krzysztof.
The point is that you should test it, not rely on us and our tools (e.g.
my or Rob's machine). If our tools report such issues, it is already too
late because it means you did not follow the process.
Best regards,
Krzysztof
next prev parent reply other threads:[~2025-03-17 11:26 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-16 11:31 [PATCH 0/3] iio:light: add driver for veml6046x00 RGBIR color sensor Andreas Klinger
2025-03-16 11:31 ` [PATCH 1/3] dt-bindings: iio: light: veml6046x00: add " Andreas Klinger
2025-03-16 12:19 ` Rob Herring (Arm)
2025-03-17 11:00 ` Jonathan Cameron
2025-03-17 11:17 ` Andreas Klinger
2025-03-17 11:26 ` Krzysztof Kozlowski [this message]
2025-03-16 11:31 ` [PATCH 2/3] iio: light: add support for veml6046x00 RGBIR " Andreas Klinger
2025-03-17 11:50 ` Jonathan Cameron
2025-03-18 2:15 ` Andreas Klinger
2025-03-23 11:51 ` Jonathan Cameron
2025-04-06 8:43 ` Andreas Klinger
2025-04-06 11:08 ` Jonathan Cameron
2025-04-07 5:52 ` Matti Vaittinen
2025-05-05 19:10 ` Andreas Klinger
2025-05-06 6:03 ` Matti Vaittinen
2025-05-06 8:28 ` Andreas Klinger
2025-05-06 9:17 ` Matti Vaittinen
2025-03-16 11:31 ` [PATCH 3/3] MAINTAINER: add maintainer for veml6046x00 Andreas Klinger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=42685f01-d864-4e68-913a-49bdb6337581@kernel.org \
--to=krzk@kernel.org \
--cc=ak@it-klinger.de \
--cc=arthur.becker@sentec.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=ivan.orlov0322@gmail.com \
--cc=javier.carrasco.cruz@gmail.com \
--cc=jic23@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mazziesaccount@gmail.com \
--cc=muditsharma.info@gmail.com \
--cc=robh@kernel.org \
--cc=subhajit.ghosh@tweaklogic.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.