From: "David Hildenbrand (Arm)" <david@kernel.org>
To: "Lorenzo Stoakes (ARM)" <ljs@kernel.org>
Cc: Vernon Yang <vernon2gm@gmail.com>,
akpm@linux-foundation.org, nico.pache@linux.dev,
ryan.roberts@arm.com, dev.jain@arm.com, baohua@kernel.org,
lance.yang@linux.dev, usama.arif@linux.dev, zokeefe@google.com,
linux-kernel@vger.kernel.org, linux-mm@kvack.org,
stable@vger.kernel.org, Vernon Yang <yanglincheng@kylinos.cn>
Subject: Re: [PATCH v3 1/3] mm: khugepaged: fix swap entry value to folio_pfn()
Date: Wed, 26 Aug 2026 10:16:59 +0200 [thread overview]
Message-ID: <42695df0-3962-4126-9afb-9a1905d096a0@kernel.org> (raw)
In-Reply-To: <ao6fSHW_nX8YC9QK@gremlin>
On 8/26/26 10:11, Lorenzo Stoakes (ARM) wrote:
> On Wed, Aug 26, 2026 at 10:08:58AM +0200, David Hildenbrand (Arm) wrote:
>> On 8/26/26 10:07, Lorenzo Stoakes (ARM) wrote:
>>>
>>> I find this name... problematic :)
>>
>> Elaborate.
>
> It's overly long, I read it and am confused as to what is 'problematic' or not,
> it reads weirdly in English and pfn_xxx is the usual convention for naming of
> pfn's anyway.
Excuse me, what? Are you now just making up arguments?
>
> I made a suggestion in the reply as to how to refactor this to avoid the need
> for assigning the name like that anyway, if you branch the result ==
> SCAN_SUCCEED then it's implied.
How is something that doesn't state the purpose make it any clearer?
--
Cheers,
David
next prev parent reply other threads:[~2026-08-26 8:17 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-24 9:29 [PATCH v3 0/3] mm: khugepaged: fix tracepoint UAF Vernon Yang
2026-08-24 9:29 ` [PATCH v3 1/3] mm: khugepaged: fix swap entry value to folio_pfn() Vernon Yang
2026-08-24 11:54 ` David Hildenbrand (Arm)
2026-08-26 2:44 ` Vernon Yang
2026-08-26 7:57 ` David Hildenbrand (Arm)
2026-08-26 8:07 ` Lorenzo Stoakes (ARM)
2026-08-26 8:08 ` David Hildenbrand (Arm)
2026-08-26 8:11 ` Lorenzo Stoakes (ARM)
2026-08-26 8:16 ` David Hildenbrand (Arm) [this message]
2026-08-26 8:24 ` David Hildenbrand (Arm)
2026-08-26 8:35 ` Lorenzo Stoakes (ARM)
2026-08-26 9:10 ` David Hildenbrand (Arm)
2026-08-26 9:21 ` Vernon Yang
2026-08-26 11:04 ` Lorenzo Stoakes (ARM)
2026-08-26 9:08 ` Vernon Yang
2026-08-24 9:29 ` [PATCH v3 2/3] mm: khugepaged: fix folio is used after pte_unmap_unlock() Vernon Yang
2026-08-24 11:57 ` David Hildenbrand (Arm)
2026-08-26 2:46 ` Vernon Yang
2026-08-26 7:58 ` David Hildenbrand (Arm)
2026-08-26 8:12 ` Lorenzo Stoakes (ARM)
2026-08-26 8:42 ` Lorenzo Stoakes (ARM)
2026-08-24 9:29 ` [PATCH v3 3/3] mm: khugepaged: fix folio is used after folio_put/unlock() Vernon Yang
2026-08-24 11:59 ` David Hildenbrand (Arm)
2026-08-26 2:47 ` Vernon Yang
2026-08-26 8:09 ` Lorenzo Stoakes (ARM)
2026-08-26 8:14 ` David Hildenbrand (Arm)
2026-08-26 8:23 ` Lorenzo Stoakes (ARM)
2026-08-26 8:41 ` Lorenzo Stoakes (ARM)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=42695df0-3962-4126-9afb-9a1905d096a0@kernel.org \
--to=david@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=baohua@kernel.org \
--cc=dev.jain@arm.com \
--cc=lance.yang@linux.dev \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=ljs@kernel.org \
--cc=nico.pache@linux.dev \
--cc=ryan.roberts@arm.com \
--cc=stable@vger.kernel.org \
--cc=usama.arif@linux.dev \
--cc=vernon2gm@gmail.com \
--cc=yanglincheng@kylinos.cn \
--cc=zokeefe@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.