All of lore.kernel.org
 help / color / mirror / Atom feed
From: Matthias-Christian Ott <matthias.christian@tiscali.de>
To: Linus Torvalds <torvalds@osdl.org>
Cc: git@vger.kernel.org,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH GIT 0.6] make use of register variables & size_t
Date: Mon, 25 Apr 2005 18:59:42 +0200	[thread overview]
Message-ID: <426D21FE.3040401@tiscali.de> (raw)
In-Reply-To: <Pine.LNX.4.58.0504250751330.18901@ppc970.osdl.org>

Linus Torvalds wrote:
> 
> On Mon, 25 Apr 2005, Matthias-Christian Ott wrote:
> 
>>The "git" didn't try store small variables, which aren't referenced, in 
>>the processor registers. It also didn't use the size_t type. I corrected 
>>a C++ style comment too.
> 
> 
> What kind of ancient C standard are you working against?
> 
> // isn't "C++" any more, and "register" variables are sooo 60's, man.
> 
> Pass the toke,
> 
> 		Linus
> 
"register" and "auto" variables aren't relicts of the 60's,  they're a 
part of the ISO-C 99 standard, I'm following, "man".

And if you think "register" variables are outdated, please remove the 
CONFIG_REGPARM option from the Kernel source.

Removing a "//" comment makes sense in this case because a "//" comment 
between hundrets of "/* */" comments looks extremly ugly and shows that 
the source is "patchworked" and unstructured.

Today a lot of people forget about the basic rules of coding. You too. :)

Matthias-Christian Ott

Literature:
[1] Dr.-Ing. Ludwig Claßen, Dipl.-Math. Ulrich Oefler: Unix und C: Ein 
Anwenderbuch; VEB Verlag Technik Berlin; 1990
[2] Erik de Castro Lopo, Peter Aitken, Bradley L. Jones: Teach Yourself 
C for Linux Programming in 21 Days; SAMS Publishing; 1999


  reply	other threads:[~2005-04-25 17:13 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-04-25 11:18 [PATCH GIT 0.6] make use of register variables & size_t Matthias-Christian Ott
2005-04-25 11:39 ` Rene Rebe
2005-04-25 12:56   ` Matthias-Christian Ott
2005-04-25 13:01     ` Matthias-Christian Ott
2005-04-25 18:06   ` David A. Wheeler
2005-04-25 12:32 ` Petr Baudis
2005-04-25 13:07   ` Pekka Enberg
2005-04-25 14:52 ` Linus Torvalds
2005-04-25 16:59   ` Matthias-Christian Ott [this message]
2005-04-25 17:12     ` Jan-Benedict Glaw
2005-04-25 17:13       ` Thomas Glanzmann
2005-04-25 17:18         ` Jan-Benedict Glaw
2005-04-25 18:23           ` Matthias-Christian Ott
2005-04-25 17:22     ` Valdis.Kletnieks
2005-04-25 17:23     ` Linus Torvalds
2005-04-25 18:15       ` Matthias-Christian Ott
2005-04-25 18:50         ` Linus Torvalds
2005-04-25 20:50           ` Arjan van de Ven
2005-04-25 18:55         ` Valdis.Kletnieks
2005-04-25 19:43           ` the REGISTER thread Brian O'Mahoney
2005-04-25 17:38     ` [PATCH GIT 0.6] make use of register variables & size_t Dmitry Torokhov
2005-04-25 17:51 ` Horst von Brand
     [not found] <3X9X6-5JP-27@gated-at.bofh.it>
2005-04-25 17:36 ` Bodo Eggert <harvested.in.lkml@posting.7eggert.dyndns.org>
     [not found] ` <3Xdel-8u2-43@gated-at.bofh.it>
     [not found]   ` <3XfpD-21C-11@gated-at.bofh.it>
2005-04-26 18:18     ` Bodo Eggert <harvested.in.lkml@posting.7eggert.dyndns.org>

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=426D21FE.3040401@tiscali.de \
    --to=matthias.christian@tiscali.de \
    --cc=git@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=torvalds@osdl.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.