From mboxrd@z Thu Jan  1 00:00:00 1970
From: Arun Sharma <arun.sharma@intel.com>
Subject: Re: [PATCH] Assorted VMX patches
Date: Mon, 25 Apr 2005 14:49:06 -0700
Message-ID: <426D65D2.20706@intel.com>
References: <20050425200356.8275510D0@huxley.watson.ibm.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xensource.com>
In-Reply-To: <20050425200356.8275510D0@huxley.watson.ibm.com>
List-Unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xensource.com>
List-Help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-Subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
Sender: xen-devel-bounces@lists.xensource.com
Errors-To: xen-devel-bounces@lists.xensource.com
To: Leendert van Doorn <leendert@watson.ibm.com>
Cc: xen-devel@lists.xensource.com
List-Id: xen-devel@lists.xenproject.org

Leendert van Doorn wrote:
> #> - ioemu: Update the address when doing a stosb/stosw/stosl. Without this
> #>   patch stosb writes req->count times at the same location req->addr. Not
> #>   exactly the intended semantics.
> # 
> # The string operations should go to the if (req->pdata_valid) clause.
> # Is pdata_valid==0 for your stos* cases?
> 
> Yes. stos* only uses a value parameter (al, ax,or eax), so pdata_valid == 0.
> Addr, size and count are still valid 
> 

ok - makes sense. Though pdata_valid is generally 1 for string 
operations (this is always true for the port i/o case), this case is an 
exception.

	-Arun