From: Jeroen Vreeken <pe1rxq@amsat.org>
To: M Taylor <mctylr@privacy.nb.ca>
Cc: Linux-Hams@vger.kernel.org
Subject: Re: MKISS DRIVER PATCH - for layer 3 longword alignment in m68000
Date: Tue, 26 Apr 2005 16:05:54 +0200 [thread overview]
Message-ID: <426E4AC2.5060906@amsat.org> (raw)
In-Reply-To: <20050426143333.A5965@pull.privacy.nb.ca>
M Taylor wrote:
>On Sun, Apr 24, 2005 at 01:40:43PM -0700, Sriram Chadalavada wrote:
>
>
>> FTP, SSH working over an AX.25 link but faced kernel
>> panics due to memory alignment issues in the mkiss
>> driver, whenever (ICMP, TCP) packets were received
>> on the relevant 'kiss' interface.
>>
>> In consultation with David McCollough
>> (Snapgear/cyberguard.com), I have come up with a
>> patch(see attachment) to solve the above problem in
>> architectures such as m68000 where alignment issues
>> are not handled in hardware.
>>
>>
>
>http://www.privacy.nb.ca/~mctylr/uClinux/mkiss-skb-align.patch
>
>
It looks ok, but there are some unneeded whitespace changes in your patch...
And on a personal note I like comments in C style more than the C++
style you use. /* ... */ instead of // ...
But that might be just me :)
Jeroen
next prev parent reply other threads:[~2005-04-26 14:05 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-04-24 20:40 MKISS DRIVER PATCH - for layer 3 longword alignment in m68000 Sriram Chadalavada
2005-04-25 15:56 ` M Taylor
2005-04-26 13:33 ` M Taylor
2005-04-26 14:05 ` Jeroen Vreeken [this message]
-- strict thread matches above, loose matches on Subject: below --
2005-05-02 19:07 Sriram Chadalavada
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=426E4AC2.5060906@amsat.org \
--to=pe1rxq@amsat.org \
--cc=Linux-Hams@vger.kernel.org \
--cc=mctylr@privacy.nb.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.