From: Thomas Monjalon <thomas@monjalon.net>
To: Ferruh Yigit <ferruh.yigit@intel.com>, Matan Azrad <matan@mellanox.com>
Cc: dev@dpdk.org
Subject: Re: [PATCH v2] ethdev: add return value to stats get dev op
Date: Wed, 11 Oct 2017 12:46:16 +0200 [thread overview]
Message-ID: <4271901.RE8S8KQ4zy@xps> (raw)
In-Reply-To: <3da5949d-71d1-43d9-1583-c5d401ee0bcb@intel.com>
11/10/2017 04:09, Ferruh Yigit:
> On 10/11/2017 3:01 AM, Ferruh Yigit wrote:
> > On 10/10/2017 9:20 PM, Matan Azrad wrote:
> >> The stats_get dev op API doesn't include return value, so PMD cannot
> >> return an error in case of failure at stats getting process time.
> >>
> >> Since PCI devices can be removed and there is a time between the
> >> physical removal to the RMV interrupt, the user may get invalid stats
> >> without any indication.
> >>
> >> This patch changes the stats_get API return value to be int instead of
> >> void.
> >>
> >> All the net PMDs stats_get dev ops are adjusted by this patch.
> >>
> >> Signed-off-by: Matan Azrad <matan@mellanox.com>
> >
> > Reviewed-by: Ferruh Yigit <ferruh.yigit@intel.com>
>
> Applied to dpdk-next-net/master, thanks.
It is breaking compilation of tests:
test/test/virtual_pmd.c:256:15: fatal error: incompatible pointer types
initializing 'eth_stats_get_t' (aka 'int (*)(struct rte_eth_dev *, struct rte_eth_stats *)')
with an expression of type 'void (struct rte_eth_dev *, struct rte_eth_stats *)'
[-Wincompatible-pointer-types]
.stats_get = virtual_ethdev_stats_get,
next prev parent reply other threads:[~2017-10-11 10:46 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-09 16:12 [PATCH 1/2] ethdev: add return value to stats get dev op Matan Azrad
2017-10-09 16:12 ` [PATCH 2/2] doc: update stats get API change Matan Azrad
2017-10-09 21:07 ` Thomas Monjalon
2017-10-09 23:57 ` [PATCH 1/2] ethdev: add return value to stats get dev op Ferruh Yigit
2017-10-10 20:20 ` [PATCH v2] " Matan Azrad
2017-10-11 2:01 ` Ferruh Yigit
2017-10-11 2:09 ` Ferruh Yigit
2017-10-11 10:46 ` Thomas Monjalon [this message]
2017-10-11 13:09 ` Andrew Rybchenko
2017-10-11 13:14 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4271901.RE8S8KQ4zy@xps \
--to=thomas@monjalon.net \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=matan@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.