From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mike Wray Subject: Re: [PATCH] xen bootloader Date: Fri, 29 Apr 2005 08:59:34 +0100 Message-ID: <4271E966.4010608@hp.com> References: <9cde8bff0504270221eded71f@mail.gmail.com> <1114744237.17750.39.camel@bree.local.net> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1114744237.17750.39.camel@bree.local.net> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Jeremy Katz Cc: "xen-devel@lists.xensource.com" List-Id: xen-devel@lists.xenproject.org Jeremy Katz wrote: > On Wed, 2005-04-27 at 18:21 +0900, aq wrote: > >>Here is a patch to fix few problems in Xen bootloader you sent to the >>list yesterday. > > Thanks. Sorry for the delay in responding, I've been underwater with > stuff for FC4 test3. > >>list of changes: >>- make a dummy tools/pygrub/src/__init__.py > > I still don't know why this didn't work, but thanks. > >>- extend filesystem abstraction by adding file_exist() method. this >>method is used to check for existent of a file given its name. now >>ext2fs implements this method. > > Great, thanks. My only comment about the ext2fs code for this is that > you might as well inline the contents of ext2_file_exist in > ext2fs_file_exist... you don't gain anything by having that for reuse > that I can see. > >>- pygrub opens and parses /boot/grub/menu.lst or /boot/grub/grub.conf, >>in that order. >>- add /usr/lib/python to system path (see pygrub). without this >>change, pygrub cannot find grub python package. > > Per the other changes I submitted a week or so ago, you want to append > this to the path, not prepend it. > > >>- remove few blank lines > > > Fair enough. > >>$ diffstat xen-grub.patch >> __init__.py | 1 >> fsys/__init__.py | 5 +++- >> fsys/ext2/ext2module.c | 51 ++++++++++++++++++++++++++++++++++++++++--------- >> pygrub | 12 +++++++++-- >> 4 files changed, 57 insertions(+), 12 deletions(-) >> >>Signed-off-by: Nguyen Anh Quynh > > > I'll apply this to my local tree. Mike -- based on your later mail, > should I gather that you've applied things to your tree and are in the > process of pushing to -unstable? Or should I go about trying to do > something more sane to maintain this on the side for a while? Yes, I've applied the patch and it should be making its way out to unstable, possibly today. BTW, I had to install e2fsprogs-devel before it would compile, so I added a note that you need that in a README. >>I wonder why the patch you sent to list is in CR/LF format? arent you >>programming on Windows, are you ;-). could you please remove them next >>time ? > > > Hrmm, I have no clue either. The previous patch appears to not be in > DOS format but the second one is. And they should have been exported > identically from my local bk repository. I'll double-check next time > before sending. Mike