From: Alejandro Colomar <colomar.6.4.3@gmail.com>
To: "Michael Kerrisk (man-pages)" <mtk.manpages@gmail.com>
Cc: linux-man@vger.kernel.org, libc-alpha@sourceware.org
Subject: Re: [PATCH 2/9] system_data_types.7: srcfix: Add FIXME note: Add descriptions
Date: Fri, 18 Sep 2020 23:35:43 +0200 [thread overview]
Message-ID: <4273bd1f-8af2-2fae-3017-e6333a3131af@gmail.com> (raw)
In-Reply-To: <87b7b1b8-7a37-7ff6-49b5-11a9e7710276@gmail.com>
Hi Michael,
On 2020-09-18 23:03, Michael Kerrisk (man-pages) wrote:
> Hi Alex,
>
> On 9/18/20 10:50 PM, Michael Kerrisk (man-pages) wrote:
>> On 9/18/20 7:04 PM, Alejandro Colomar wrote:
>>> Signed-off-by: Alejandro Colomar <colomar.6.4.3@gmail.com>
>>
>>
>> Thanks, Alex. Patch applied.
>
> Sorry -- I misspoke. This pach doesn't apply. It wasn't obvious why.
>
> But, yes, I think adding a description would be good.
>
> Thanks,
>
> Michael
>
>>> ---
>>> man7/system_data_types.7 | 2 ++
>>> 1 file changed, 2 insertions(+)
>>>
>>> diff --git a/man7/system_data_types.7 b/man7/system_data_types.7
>>> index 5352f3ef2..48871e4eb 100644
>>> --- a/man7/system_data_types.7
>>> +++ b/man7/system_data_types.7
>>> @@ -96,6 +96,8 @@ typedef struct {
>>> * the end of substring */
>>> } regmatch_t;
>>> .EE
>>> +.\".IP
>>> +.\" FIXME: Add a description?
>>> .IP
>>> Conforming to: POSIX.1-2001 and later.
>>> .IP
I added that comment to every type that lacks a description so that we
can see them easier. In other types I embedded that comment in the
patch with the documentation, but in this case, the type was already
documented, so I had to add an extra commit.
Cheers,
Alex
next prev parent reply other threads:[~2020-09-18 21:35 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-18 17:04 [PATCH 0/9] Document aiocb, sigevent, siginfo_t Alejandro Colomar
2020-09-18 17:04 ` [PATCH 1/9] system_data_types.7: ffix Alejandro Colomar
2020-09-18 20:49 ` Michael Kerrisk (man-pages)
2020-09-18 17:04 ` [PATCH 2/9] system_data_types.7: srcfix: Add FIXME note: Add descriptions Alejandro Colomar
2020-09-18 20:50 ` Michael Kerrisk (man-pages)
2020-09-18 21:03 ` Michael Kerrisk (man-pages)
2020-09-18 21:35 ` Alejandro Colomar [this message]
2020-09-18 17:04 ` [PATCH 3/9] system_data_types.7: Document sigevent Alejandro Colomar
2020-09-18 21:09 ` Michael Kerrisk (man-pages)
2020-09-18 21:36 ` Alejandro Colomar
2020-09-18 17:04 ` [PATCH 4/9] sigevent.3: New link to new documented type in system_data_types(7) Alejandro Colomar
2020-09-18 21:10 ` Michael Kerrisk (man-pages)
2020-09-18 21:39 ` Alejandro Colomar
2020-09-18 21:43 ` Michael Kerrisk (man-pages)
2020-09-18 21:57 ` Alejandro Colomar
2020-09-19 8:11 ` Michael Kerrisk (man-pages)
2020-09-18 17:04 ` [PATCH 5/9] system_data_types.7: srcfix: cosmetic: Visually sparate types Alejandro Colomar
2020-09-18 21:14 ` Michael Kerrisk (man-pages)
2020-09-18 17:04 ` [PATCH 6/9] system_data_types.7: Document aiocb Alejandro Colomar
2020-09-18 17:04 ` [PATCH 7/9] aiocb.3: New link to new documented type in system_data_types(7) Alejandro Colomar
2020-09-18 21:28 ` Michael Kerrisk (man-pages)
2020-09-18 17:04 ` [PATCH 8/9] system_data_types.7: Document siginfo_t Alejandro Colomar
2020-09-18 21:42 ` Michael Kerrisk (man-pages)
2020-09-18 21:45 ` Alejandro Colomar
2020-09-20 18:05 ` [PATCH v2 " Alejandro Colomar
2020-09-20 20:19 ` Michael Kerrisk (man-pages)
2020-09-20 18:05 ` [PATCH v2 9/9] siginfo_t.3: New link to new documented type in system_data_types(7) Alejandro Colomar
2020-09-20 20:19 ` Michael Kerrisk (man-pages)
2020-09-18 17:04 ` [PATCH " Alejandro Colomar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4273bd1f-8af2-2fae-3017-e6333a3131af@gmail.com \
--to=colomar.6.4.3@gmail.com \
--cc=libc-alpha@sourceware.org \
--cc=linux-man@vger.kernel.org \
--cc=mtk.manpages@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.