Re: [dpdk-dev] [PATCH 00/16] NXP DPAAx fixes and enhancements

[Thomas Monjalon <thomas@monjalon.net>]

08/04/2020 09:52, Dodji Seketeli:
> Hello Thomas, Hemant,
> 
> Thomas Monjalon <thomas@monjalon.net> writes:
> > 07/04/2020 12:25, Hemant Agrawal:
> 
> [...]
> 
> >> [Hemant] I have commented on Neil's series.
> >> It needs more changes in existing code.
> >> An approach like __rte_experimental will work better.
> >
> > I guess you mean __rte_internal?
> >
> > Please Hemant don't wait for someone else filling the gap.
> > If __rte_internal is the right approach, please complete and use it.
> 
> Just so that I understand, is __rte_internal an ELF version that the
> symbols per_lcore_dpaa2_held_bufs, dpaa2_io_portal and
> per_lcore__dpaa2_io should have in the binary?

Correct

> If that is the case, then it seems to me that the __rte_internal
> approach that you are suggesting would be a much better approach that
> the one I replied to Hemant about below.

Yes I think we all agree, just waiting for the patch to be ready.

> I didn't mean to tell Hemant what approach he should take :-) I was just
> trying to help him get the syntax of a libabigail suppression
> specification right.
> 
> Sorry for the confusion I might have induced.

No problem, thanks for the help.