All of lore.kernel.org
 help / color / mirror / Atom feed
From: Pablo Neira <pablo@eurodev.net>
To: Netfilter Development Mailinglist <netfilter-devel@lists.netfilter.org>
Cc: Patrick McHardy <kaber@trash.net>, KOVACS Krisztian <hidden@balabit.hu>
Subject: [PATCH] Delete nfcache use in ip_table
Date: Thu, 05 May 2005 18:15:25 +0200	[thread overview]
Message-ID: <427A469D.8030305@eurodev.net> (raw)

[-- Attachment #1: Type: text/plain, Size: 618 bytes --]

Hi Patrick,

Since we've removed the use of nfcache in iptables, I think that it 
should be remove in ip_tables.c as well because:

a) there's no utility on it
b) it can be source of interferences for the conntrack-event-api, and 
thus for conntrack_netlink and ct_sync.

Please see the email labeled as:
[Re: BUG/CONFLICT conntrack with preroute/postroute mangle table]

I could keep this as a seperate patch in conntrack-event-api pom-ng, but 
I prefer kill it now and forget about it. If you've got no reason to 
object, please then pass it to davem.

Signed-off-by: Pablo Neira Ayuso <pablo@eurodev.net>

--
Pablo

[-- Attachment #2: y --]
[-- Type: text/plain, Size: 505 bytes --]

Index: net/ipv4/netfilter/ip_tables.c
===================================================================
--- 6d7098bc350768f59a41090ca248ae430cd95b25/net/ipv4/netfilter/ip_tables.c  (mode:100644 sha1:8a54f92b8496a4218a243c35ab2b55ec659e7d18)
+++ uncommitted/net/ipv4/netfilter/ip_tables.c  (mode:100644)
@@ -313,7 +313,6 @@
 	do {
 		IP_NF_ASSERT(e);
 		IP_NF_ASSERT(back);
-		(*pskb)->nfcache |= e->nfcache;
 		if (ip_packet_match(ip, indev, outdev, &e->ip, offset)) {
 			struct ipt_entry_target *t;
 

             reply	other threads:[~2005-05-05 16:15 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-05-05 16:15 Pablo Neira [this message]
2005-05-05 16:29 ` [PATCH] Delete nfcache use in ip_table Patrick McHardy
2005-05-06  0:25   ` Pablo Neira
2005-05-06  6:56     ` Jonas Berlin
2005-05-06 15:24       ` Patrick McHardy
2005-05-07  4:44         ` Jonas Berlin
2005-05-06 15:05     ` Patrick McHardy
2005-07-11  9:51     ` Amin Azez
2005-05-05 21:21 ` KOVACS Krisztian

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=427A469D.8030305@eurodev.net \
    --to=pablo@eurodev.net \
    --cc=hidden@balabit.hu \
    --cc=kaber@trash.net \
    --cc=netfilter-devel@lists.netfilter.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.