From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S262118AbVEERiJ (ORCPT ); Thu, 5 May 2005 13:38:09 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S262160AbVEERiJ (ORCPT ); Thu, 5 May 2005 13:38:09 -0400 Received: from hellhawk.shadowen.org ([80.68.90.175]:55312 "EHLO hellhawk.shadowen.org") by vger.kernel.org with ESMTP id S262118AbVEERiG (ORCPT ); Thu, 5 May 2005 13:38:06 -0400 Message-ID: <427A59BC.1020208@shadowen.org> Date: Thu, 05 May 2005 18:37:00 +0100 From: Andy Whitcroft User-Agent: Debian Thunderbird 1.0.2 (X11/20050331) X-Accept-Language: en-us, en MIME-Version: 1.0 To: Olof Johansson CC: linuxppc64-dev@ozlabs.org, paulus@samba.org, anton@samba.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, haveblue@us.ibm.com, kravetz@us.ibm.com Subject: Re: [3/3] sparsemem memory model for ppc64 References: <20050505023132.GB20283@austin.ibm.com> In-Reply-To: <20050505023132.GB20283@austin.ibm.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Olof Johansson wrote: > Hi, > > Just two formatting nitpicks below. Thanks, this would be better served by rewriting the first comment and removing the second all together. /* Add all physical memory to the bootmem map, mark each area * present. The first block has already been marked present above. */ I note that the diff in question has sneaked into the wrong patch, that segement represents memory_present. So I'll rediff them with it there. No overall change to the code. -apw From mboxrd@z Thu Jan 1 00:00:00 1970 Message-ID: <427A59BC.1020208@shadowen.org> Date: Thu, 05 May 2005 18:37:00 +0100 From: Andy Whitcroft MIME-Version: 1.0 Subject: Re: [3/3] sparsemem memory model for ppc64 References: <20050505023132.GB20283@austin.ibm.com> In-Reply-To: <20050505023132.GB20283@austin.ibm.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org Return-Path: To: Olof Johansson Cc: linuxppc64-dev@ozlabs.org, paulus@samba.org, anton@samba.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, haveblue@us.ibm.com, kravetz@us.ibm.com List-ID: Olof Johansson wrote: > Hi, > > Just two formatting nitpicks below. Thanks, this would be better served by rewriting the first comment and removing the second all together. /* Add all physical memory to the bootmem map, mark each area * present. The first block has already been marked present above. */ I note that the diff in question has sneaked into the wrong patch, that segement represents memory_present. So I'll rediff them with it there. No overall change to the code. -apw -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: aart@kvack.org