Re: [PATCH] Delete nfcache use in ip_table

[Patrick McHardy <kaber@trash.net>]

Pablo Neira wrote:
> Patrick McHardy wrote:
> 
>> No objections, but please remove it in all files under
>> net/ipv4/netfilter.
> 
> I've deleted all references to nfcache found in ipv4 and ipv6.

Thanks. I thought we couldn't remove them in ipv6/ because
ip6_maybe_reroute() reroutes packets with NFC_ALTERED, but
the flag wasn't set on any change that could affect routing,
so it should be fine. I've removed ip6_maybe_reroute() and
killed one more NFC_ALTERED in net/bridge.

> While I was at it, I thought about killing NFC_* stuff in
> include/linux/netfilter[_ipv4].h, then I realized that old iptables
> versions won't compile if I do so. Those will have to remain there to
> ensure backward compatibility compilation.

Yes, we can kill them once iptables versions that still include
them don't work anymore for other reasons.

BTW: Please also sign off resends. I've used the line from your first
patch.

Regards
Patrick