From: Patrick McHardy <kaber@trash.net>
To: Patrick McHardy <kaber@trash.net>
Cc: Asim Shankar <asimshankar@gmail.com>, netdev@oss.sgi.com
Subject: Re: SFQ: Reordering?
Date: Sat, 07 May 2005 00:46:28 +0200 [thread overview]
Message-ID: <427BF3C4.1030105@trash.net> (raw)
In-Reply-To: <427BEAAE.409@trash.net>
Patrick McHardy wrote:
> Asim Shankar wrote:
>
>>Should complete rehashing take place in sfq_perturbation(), or am I
>>missing something? (I was looking at 2.6.9 and also took a cursory
>>glance at 2.6.11 on lxr.linux.no)
>
>
> I think we should rehash. Can you send a patch?
Hmm wait, this is not so easy. We can't rehash by going over
the buckets one by one. If we do so and we have a new clash of
two flows previously contained in different buckets the packets
will afterwards be sorted by flow in their new bucket. To retain
fairness we need to iterate over all buckets containing packets
and rehash them one packet per a bucket at a time. But this means
we need lots of temporary storage to store the queues while
rehashing. Can anyone thing of a better solution?
next prev parent reply other threads:[~2005-05-06 22:46 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-05-06 21:53 SFQ: Reordering? Asim Shankar
2005-05-06 22:07 ` Patrick McHardy
2005-05-06 22:46 ` Patrick McHardy [this message]
2005-05-06 23:02 ` Thomas Graf
2005-05-06 23:19 ` Patrick McHardy
2005-05-07 0:58 ` Thomas Graf
2005-05-07 1:28 ` Patrick McHardy
2005-05-08 11:51 ` Thomas Graf
2005-05-08 16:03 ` Patrick McHardy
2005-05-08 18:33 ` Thomas Graf
2005-05-09 23:14 ` Andy Furniss
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=427BF3C4.1030105@trash.net \
--to=kaber@trash.net \
--cc=asimshankar@gmail.com \
--cc=netdev@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.