All of lore.kernel.org
 help / color / mirror / Atom feed
From: r.marek@sh.cvut.cz (Rudolf Marek)
To: lm-sensors@vger.kernel.org
Subject: ESB2 SMBUS - validation request
Date: Thu, 19 May 2005 06:25:57 +0000	[thread overview]
Message-ID: <427E318D.7050908@sh.cvut.cz> (raw)

Hello,

I noticed that you added ESB2 support to i2c-i801.c Thats OK for 2.6 kernels
however for 2.4.x series it is needed too. (lm_sensors lives outside 2.4 tree
and its homepage is at http://www.lm-sensors.nu)

I created neccessary patch that adds support to 2.4.x i2c-i801.c and to our
sensors-detect script, but I need to confirm that:

1) the SMBUS host supports PEC
2) the PCI "function" is 3
3) it is OK to call it "Intel Enterprise Southbridge - ESB2"

I failed to find datasheet for it so any point to it for future reference would
be perfect. (Or just state it is same as in 6300ESB)

What is left is documentattion update in doc/ directory.
I will also update 2.6.12-rc4/Documentation/i2c/busses/i2c-i801 file.

Regards

Rudolf

FIY: here is what files were modified and how.

--- lm_sensors2/kernel/busses/i2c-i801.c	
+++ lm_sensors2_zmena/kernel/busses/i2c-i801.c
@@ -31,6 +31,7 @@
     6300ESB		25A4   ("")
     ICH6		266A   ("")
     ICH7		27DA   ("")
+    ESB2 		269B   ("")
     This driver supports several versions of Intel's I/O Controller Hubs (ICH).
     For SMBus support, they are similar to the PIIX4 and are part
     of Intel's '810' and other chipsets.
@@ -75,6 +76,11 @@
 #define PCI_DEVICE_ID_INTEL_ESB_4	0x25a4
 #endif

+/* ESB2 - Enterprise Southbridge is undefined */
+#ifndef PCI_DEVICE_ID_INTEL_ESB2_17
+#define PCI_DEVICE_ID_INTEL_ESB2_17 	0x269b
+#endif
+
 /* ICH6 is undefined */
 #ifndef PCI_DEVICE_ID_INTEL_ICH6_16
 #define PCI_DEVICE_ID_INTEL_ICH6_16	0x266a
@@ -160,6 +166,7 @@
 	if (dev->device = PCI_DEVICE_ID_INTEL_82801DB_3 ||
 	    dev->device = PCI_DEVICE_ID_INTEL_82801EB_3 ||
 	    dev->device = PCI_DEVICE_ID_INTEL_ESB_4 ||
+	    dev->device = PCI_DEVICE_ID_INTEL_ESB2_17 ||	
 	    dev->device = PCI_DEVICE_ID_INTEL_ICH6_16 ||
 	    dev->device = PCI_DEVICE_ID_INTEL_ICH7_17)
 		isich4 = 1;
@@ -658,6 +665,12 @@
 	},
 	{
 		.vendor =	PCI_VENDOR_ID_INTEL,
+		.device =	PCI_DEVICE_ID_INTEL_ESB2_17,
+		.subvendor =	PCI_ANY_ID,
+		.subdevice = 	PCI_ANY_ID,
+	},
+	{
+		.vendor =	PCI_VENDOR_ID_INTEL,
 		.device =	PCI_DEVICE_ID_INTEL_ICH6_16,
 		.subvendor =	PCI_ANY_ID,
 		.subdevice =	PCI_ANY_ID,
--- lm_sensors2/prog/detect/sensors-detect
+++ lm_sensors2_zmena/prog/detect/sensors-detect
@@ -132,6 +132,14 @@
      } ,
      {
        vendid => 0x8086,
+       devid  => 0x269B,
+       func => 3,
+       procid => "Intel Enterprise Southbridge - ESB2",
+       driver => "i2c-i801",
+       match => sub { $_[0] =~ /^SMBus I801 adapter at [0-9a-f]{4}/ },
+     } ,
+     {
+       vendid => 0x8086,
        devid  => 0x266A,
        func => 3,
        procid => "Intel 82801FB ICH6",

             reply	other threads:[~2005-05-19  6:25 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-05-19  6:25 Rudolf Marek [this message]
2005-05-19  6:25 ` ESB2 SMBUS - validation request Jean Delvare
2005-05-19  6:25 ` Rudolf Marek
2005-05-19  6:25 ` Jean Delvare

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=427E318D.7050908@sh.cvut.cz \
    --to=r.marek@sh.cvut.cz \
    --cc=lm-sensors@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.