All of lore.kernel.org
 help / color / mirror / Atom feed
From: Brad Midgley <bmidgley@xmission.com>
To: bluez-devel@lists.sourceforge.net
Subject: Re: [Bluez-devel] Regarding a2recv
Date: Sun, 08 May 2005 22:29:40 -0600	[thread overview]
Message-ID: <427EE734.4030303@xmission.com> (raw)
In-Reply-To: <20050509005413.3787d2d7.henryk@ploetzli.ch>

Henryk

> there should only be one struct that includes a struct avdtp_header and
> a union with all the other optional signalling contents. Then there
> would have to be specialised read()/write() functions which figure out
> (based on the header) how long the packet actually is and automatically
> send/receive that many bytes. However, that would also require
> modification of a2play so I thought I'd ask first.

I think this part sounds better, especially if Marcel thinks this is 
closer to what it will look like if/when it's "kernelized" :)

The only tricky part is the MAX_ADDITIONAL_CODEC stuff. Make sure we 
only try to send one codec when we're reporting our sink's capabilities 
and accept multiple codecs when we're reading capabilities.

Maybe what you're proposing will clean up the "optional" error codes in 
places like open_stream_rsp. The header would look different so you 
could distinguish the error codes and compute the size properly when 
sending. Be sure we accept the extended size with the error codes when 
receiving.

Brad


-------------------------------------------------------
This SF.Net email is sponsored by: NEC IT Guy Games.
Get your fingers limbered up and give it your best shot. 4 great events, 4
opportunities to win big! Highest score wins.NEC IT Guy Games. Play to
win an NEC 61 plasma display. Visit http://www.necitguy.com/?r=20
_______________________________________________
Bluez-devel mailing list
Bluez-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/bluez-devel

  parent reply	other threads:[~2005-05-09  4:29 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-05-05 12:45 [Bluez-devel] Regarding a2recv Mayank Batra
2005-05-05 13:14 ` Marcel Holtmann
2005-05-05 14:40 ` Brad Midgley
2005-05-06  4:05 ` Henryk Plötz
2005-05-08 12:50   ` Mayank Batra
2005-05-08 22:54     ` Henryk Plötz
2005-05-09  0:01       ` Marcel Holtmann
2005-05-09  0:58         ` Henryk Plötz
2005-05-09  1:03           ` Marcel Holtmann
2005-05-09  1:35             ` Henryk Plötz
2005-05-09  1:44               ` Marcel Holtmann
2005-05-09  4:29               ` Brad Midgley
2005-05-09 12:48                 ` Henryk Plötz
2005-05-09 12:58                   ` Marcel Holtmann
2005-05-09 16:25                   ` Brad Midgley
2005-05-09  4:29       ` Brad Midgley [this message]
2005-05-09 12:38         ` Henryk Plötz
2005-05-09 21:31           ` Brad Midgley
2005-05-10  7:20       ` Mayank Batra

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=427EE734.4030303@xmission.com \
    --to=bmidgley@xmission.com \
    --cc=bluez-devel@lists.sourceforge.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.