All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jakob Hirsch <jh@plonk.de>
To: mlmmj@mlmmj.org
Subject: Re: 1.2.6 released. No more queue littering ...
Date: Mon, 09 May 2005 12:47:02 +0000	[thread overview]
Message-ID: <427F5BC6.7040907@plonk.de> (raw)
In-Reply-To: <20050508182645.GF87309@mmj.dk>

Mads Martin Joergensen wrote:

>> o If prefix but no Subject: header is present, add one (Jakob Hirsch)
> There's a bug here. In case we meet a subject already we forget to clear
> the flag. This patch should fix it, so that no 2 subjects are present:

> +                               subject_present = 1;

It's there (a few lines below), but will only be done if the subject 
contains the prefix, which is obiously wrong.
sorry for that.

the extra setting of subject_present doesn't hurt, but for clarity, it's 
better to remove it:

--- do_all_the_voodo_here.c   2005-05-08 18:18:02 +0200
+++ do_all_the_voodo_here.c   2005-05-09 14:41:41 +0200
@@ -153,7 +154,6 @@
                                         myfree(subject);
                                         myfree(hdrline);
                                         myfree(unqp);
-                                       subject_present = 1;
                                         continue;
                                 }
                                 myfree(unqp);

  parent reply	other threads:[~2005-05-09 12:47 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-05-08 18:26 1.2.6 released. No more queue littering Mads Martin Joergensen
2005-05-09  7:16 ` Mads Martin Joergensen
2005-05-09 12:47 ` Jakob Hirsch [this message]
2005-05-09 12:48 ` Mads Martin Joergensen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=427F5BC6.7040907@plonk.de \
    --to=jh@plonk.de \
    --cc=mlmmj@mlmmj.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.