From: oleksii.kurochko@gmail.com
To: Jan Beulich <jbeulich@suse.com>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>,
Julien Grall <julien@xen.org>,
Stefano Stabellini <sstabellini@kernel.org>,
xen-devel@lists.xenproject.org
Subject: Re: [PATCH v4 2/6] xen: define ACPI and DT device info sections macros
Date: Fri, 27 Sep 2024 11:24:18 +0200 [thread overview]
Message-ID: <427c90f5824732790449a1dcba9e94facd04a462.camel@gmail.com> (raw)
In-Reply-To: <18b146cf-c49f-4133-ac21-b710bf59d113@suse.com>
On Fri, 2024-09-27 at 09:28 +0200, Jan Beulich wrote:
> On 26.09.2024 18:54, Oleksii Kurochko wrote:
> > --- a/xen/include/xen/xen.lds.h
> > +++ b/xen/include/xen/xen.lds.h
> > @@ -120,6 +120,14 @@
> >
> > /* List of constructs other than *_SECTIONS in alphabetical order.
> > */
> >
> > +#define ACPI_DEV_INFO(secname) \
> > + . = ALIGN(POINTER_ALIGN); \
> > + DECL_SECTION(secname) { \
> > + _asdevice = .; \
> > + *(secname) \
> > + _aedevice = .; \
> > + } :text
> > +
> > #define BUGFRAMES \
> > __start_bug_frames_0 = .; \
> > *(.bug_frames.0) \
> > @@ -137,6 +145,14 @@
> > *(.bug_frames.3) \
> > __stop_bug_frames_3 = .;
> >
> > +#define DT_DEV_INFO(secname) \
> > + . = ALIGN(POINTER_ALIGN); \
> > + DECL_SECTION(secname) { \
> > + _sdevice = .; \
> > + *(secname) \
> > + _edevice = .; \
> > + } :text
> > +
> > #ifdef CONFIG_HYPFS
> > #define HYPFS_PARAM \
> > . = ALIGN(POINTER_ALIGN); \
>
> Michal's comment made me notice that I overlooked the section names
> being
> macro parameters. Why's that?
I wanted to give ability for architecture to choose the name but now I
am realized that it isn't corrected as common code is using specific
names ".adev.info" and ".dev.info".
I will prepare the new version of patch series with dropped macro
parameter and just hardcode the name of the section inside the macros.
~ Oleksii
next prev parent reply other threads:[~2024-09-27 9:24 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-26 16:54 [PATCH v4 0/6] Move {acpi_}device_init() and device_get_class() to common code Oleksii Kurochko
2024-09-26 16:54 ` [PATCH v4 1/6] xen: introduce SIMPLE_DECL_SECTION Oleksii Kurochko
2024-09-27 6:36 ` Jan Beulich
2024-09-27 7:58 ` Roger Pau Monné
2024-09-27 9:07 ` oleksii.kurochko
2024-09-27 9:41 ` Roger Pau Monné
2024-09-27 10:42 ` oleksii.kurochko
2024-09-27 11:59 ` Jan Beulich
2024-09-26 16:54 ` [PATCH v4 2/6] xen: define ACPI and DT device info sections macros Oleksii Kurochko
2024-09-27 6:38 ` Jan Beulich
2024-09-27 7:28 ` Jan Beulich
2024-09-27 9:24 ` oleksii.kurochko [this message]
2024-09-26 16:54 ` [PATCH v4 3/6] xen/arm: use {DT,ACPI}_DEV_INFO for device info sections Oleksii Kurochko
2024-09-27 7:16 ` Michal Orzel
2024-09-27 9:17 ` oleksii.kurochko
2024-09-26 16:54 ` [PATCH v4 4/6] xen/ppc: add section for device information in linker script Oleksii Kurochko
2024-09-26 16:54 ` [PATCH v4 5/6] xen/riscv: " Oleksii Kurochko
2024-09-27 6:39 ` Jan Beulich
2024-09-26 16:54 ` [PATCH v4 6/6] xen/common: move device initialization code to common code Oleksii Kurochko
2024-09-27 7:40 ` Michal Orzel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=427c90f5824732790449a1dcba9e94facd04a462.camel@gmail.com \
--to=oleksii.kurochko@gmail.com \
--cc=andrew.cooper3@citrix.com \
--cc=jbeulich@suse.com \
--cc=julien@xen.org \
--cc=sstabellini@kernel.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.