From mboxrd@z Thu Jan  1 00:00:00 1970
From: Hollis Blanchard <hollisb@us.ibm.com>
Subject: Re: recent major -unstable changes cause ia64 build to
	be	broken
Date: Tue, 10 May 2005 16:35:24 -0500
Message-ID: <4281291C.8090305@us.ibm.com>
References: <516F50407E01324991DD6D07B0531AD542CA2F@cacexc12.americas.cpqcorp.net>
Mime-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xensource.com>
In-Reply-To: <516F50407E01324991DD6D07B0531AD542CA2F@cacexc12.americas.cpqcorp.net>
List-Unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xensource.com>
List-Help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-Subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
Sender: xen-devel-bounces@lists.xensource.com
Errors-To: xen-devel-bounces@lists.xensource.com
To: "Magenheimer, Dan (HP Labs Fort Collins)" <dan.magenheimer@hp.com>
Cc: xen-devel <xen-devel@lists.xensource.com>
List-Id: xen-devel@lists.xenproject.org

Magenheimer, Dan (HP Labs Fort Collins) wrote:
> 
> The biggest problem was due to the removal of three
> includes from include/xen/slab.h... this was obscured
> by some of the other changes.
> 
> Could you put these back in where they were before please?
> (If necessary, with a ifdef ia64 for now and we can sort
> it out later.)
> 
> < #include <xen/mm.h>
> < #include <xen/cache.h>
> < #include <xen/types.h> 
> 
> Actually, it appears I only need xen/mm.h if that helps.

I needed to include xen/mm.h in a handful of (common) places with the
new code:
	xen/common/page_alloc.c
	xen/common/schedule.c
	xen/drivers/char/console.c

These files all use things from xen/mm.h, but do not include it. Here I
will repeat my point about relying on implicit includes... :)

-- 
Hollis Blanchard
IBM Linux Technology Center