Re: [RFC][patch 1/2] new system call, unshare

[Janak Desai <janak@us.ibm.com>]

Jonathan Corbet wrote:
> Janak Desai <janak@us.ibm.com> wrote:
> 
> 
>>+asmlinkage long sys_unshare(unsigned long unshare_flags)
>>+{
>>[...]
>>
>>+	if (!(unshare_flags & (CLONE_NEWNS | CLONE_VM | CLONE_SIGHAND)))
>>+		goto bad_unshare_invalid_val;
> 
> 
> If I read this function correctly, it will silently ignore any flags
> other than the three above, as long as at least one of those three is
> present.  It might be a good idea to fail the call if any unrecognized
> flags are present or you risk changing application behavior in the
> future if any new flags are added.
> 

Ok, thanks Jonathan. I will update the patch accordingly.

-Janak