From: Carsten Otte <cotte@freenet.de>
To: Badari Pulavarty <pbadari@us.ibm.com>
Cc: Christoph Hellwig <hch@infradead.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
linux-fsdevel <linux-fsdevel@vger.kernel.org>,
schwidefsky@de.ibm.com, Andrew Morton <akpm@osdl.org>
Subject: Re: [RFC/PATCH 2/5] mm/fs: add execute in place support
Date: Wed, 11 May 2005 18:19:09 +0200 [thread overview]
Message-ID: <4282307D.8060307@freenet.de> (raw)
In-Reply-To: <1115826428.26913.1069.camel@dyn318077bld.beaverton.ibm.com>
Badari Pulavarty wrote:
> While I agree with your reasoning, since you are affecting very hot
>
>code path for every architecture, irrespective of "bdev" support
>for this - you may want to look into some how eliminating few
>function pointer de-refs and checks for those who don't care.
>(#ifdef, unlikely(), or some arch & config magic).
>
>
I do agree that addidional pointer derefs would be a nightmare
from the performance perspective. But afaics the patch does not
add such, and for checks I did already add likeleyness for the non-xip
case. Could you be more precise and specify which code path(es) you
mean?
>To be honest, that file is already complicated enough - every time
>I look at it my head hurts :(
>
>
I agree on that one. I gonna put extra functions into its own file.
next prev parent reply other threads:[~2005-05-11 16:19 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-05-11 14:30 [RFC/PATCH 2/5] mm/fs: add execute in place support Carsten Otte
2005-05-11 15:09 ` Christoph Hellwig
2005-05-11 15:33 ` Carsten Otte
2005-05-11 15:47 ` Badari Pulavarty
2005-05-11 16:19 ` Carsten Otte [this message]
2005-05-11 17:31 ` Arnd Bergmann
2005-05-11 17:47 ` Carsten Otte
2005-05-11 17:50 ` Matthew Wilcox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4282307D.8060307@freenet.de \
--to=cotte@freenet.de \
--cc=akpm@osdl.org \
--cc=hch@infradead.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pbadari@us.ibm.com \
--cc=schwidefsky@de.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.