From: mds@mds.gotdns.com (Mark Studebaker)
To: lm-sensors@vger.kernel.org
Subject: Setting w83627hf fan divisor 128 fails.
Date: Thu, 19 May 2005 06:25:58 +0000 [thread overview]
Message-ID: <428238A8.5000805@mds.gotdns.com> (raw)
In-Reply-To: <20050508193026.GA777@smooth.piipiip.net>
check in
thanks
Jarkko Lavinen wrote:
> Hi all
>
> I couldn't set the divisor 128 through fan1_div sysfs entry even though the
> chip supports it and setting divisors 1..64 worked. This was due to
> POWER_TO_REG() only checking 2's powers 0 till 5 but not 6.
>
> Regards
> Jarkko Lavinen
>
> --- linux-2.6.12-rc3/drivers/i2c/chips/w83627hf.c 2005-04-21 03:03:13.000000000 +0300
> +++ linux-2.6.12-rc3-koe/drivers/i2c/chips/w83627hf.c 2005-05-08 20:04:04.000000000 +0300
> @@ -264,7 +264,7 @@ static inline u8 DIV_TO_REG(long val)
> {
> int i;
> val = SENSORS_LIMIT(val, 1, 128) >> 1;
> - for (i = 0; i < 6; i++) {
> + for (i = 0; i < 7; i++) {
> if (val = 0)
> break;
> val >>= 1;
>
prev parent reply other threads:[~2005-05-19 6:25 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-05-19 6:25 Setting w83627hf fan divisor 128 fails Jarkko Lavinen
2005-05-19 6:25 ` Grant Coady
2005-05-19 6:25 ` Jean Delvare
2005-05-19 6:25 ` Mark Studebaker [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=428238A8.5000805@mds.gotdns.com \
--to=mds@mds.gotdns.com \
--cc=lm-sensors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.