From mboxrd@z Thu Jan 1 00:00:00 1970 From: Xiaofeng Ling Subject: Re: Unstableness in grant table block drivers Date: Thu, 12 May 2005 09:50:56 +0800 Message-ID: <4282B680.7060006@intel.com> References: <20050416153922.GH27157@us.ibm.com> <20050418205103.GC19115@us.ibm.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: cwc22@cam.ac.uk Cc: Ryan Harper , xen-devel@lists.xensource.com List-Id: xen-devel@lists.xenproject.org I found there is bug in the 2.4 vbd grant table code ===== xen-bk/linux-2.6.11-xen-sparse/drivers/xen/blkfront/blkfront.c 1.53 vs edited ===== --- 1.53/linux-2.6.11-xen-sparse/drivers/xen/blkfront/blkfront.c 2005-04-21 17:14:12 +08:00 +++ edited/xen-bk/linux-2.6.11-xen-sparse/drivers/xen/blkfront/blkfront.c 2005-05-12 09:15:38 +08:00 @@ -824,7 +824,7 @@ buffer_ma >> PAGE_SHIFT, ( operation == BLKIF_OP_WRITE ? 1 : 0 ) ); - blk_shadow[id].frame[req->nr_segments] = + blk_shadow[req->id].frame[req->nr_segments] = buffer_ma >> PAGE_SHIFT; req->frame_and_sects[req->nr_segments] = Christopher Clark wrote: > Ryan > > Many thanks for taking the traces. I've located a bug in the block > backend that may or may not be the required fix -- it's a move of a > single line, see the patch below. > > c. > > Signed-off-by: Christopher Clark > > diff -Nru a/linux-2.6.11-xen-sparse/drivers/xen/blkback/blkback.c > b/linux-2.6.11-xen-sparse/drivers/xen/blkback/blkback.c > --- a/linux-2.6.11-xen-sparse/drivers/xen/blkback/blkback.c 2005-04-20 > 11:31:20 -07:00 > +++ b/linux-2.6.11-xen-sparse/drivers/xen/blkback/blkback.c 2005-04-20 > 11:31:20 -07:00 > @@ -516,11 +516,11 @@