From mboxrd@z Thu Jan 1 00:00:00 1970 From: Arun Sharma Subject: Re: Re: Should shadow_lock be spin_lock_recursive? Date: Fri, 13 May 2005 15:40:30 -0700 Message-ID: <42852CDE.7000204@intel.com> References: Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Michael A Fetterman Cc: "Ling, Xiaofeng" , xen-devel@lists.xensource.com List-Id: xen-devel@lists.xenproject.org Michael A Fetterman wrote: > > However, those calls to put_page(X) should never result in calls > to free_domheap_pages(), as X's refcount should always be >= 1 > because of the get_page performed in free_dom_mem(). > > So that tells me the refcount on X was already broken before we got > here... > Thanks for the explanation. It was a patched xen that we were testing and the problem may have been caused by our patch. We'll try to look closely at the patch to figure out why the refrence counts were wrong. -Arun