From mboxrd@z Thu Jan  1 00:00:00 1970
From: Arun Sharma <arun.sharma@intel.com>
Subject: Re: Assertion failure on shadow.c:2339 for VMX domains
Date: Fri, 13 May 2005 17:01:28 -0700
Message-ID: <42853FD8.10809@intel.com>
References: <42852AF2.40409@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xensource.com>
In-Reply-To: <42852AF2.40409@intel.com>
List-Unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xensource.com>
List-Help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-Subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
Sender: xen-devel-bounces@lists.xensource.com
Errors-To: xen-devel-bounces@lists.xensource.com
To: Michael A Fetterman <Michael.Fetterman@cl.cam.ac.uk>
Cc: xen-devel@lists.xensource.com
List-Id: xen-devel@lists.xenproject.org

Arun Sharma wrote:
> Hi Michael,
> 
> This assertion you added:
> 
> 005/05/09 mafetter   |             ASSERT(VM_ASSIST(d, 
> VMASST_TYPE_writable_pagetables));
> 
> is failing for VMX domains. Why do you think this assertion belongs there?

Ditto for the other two below as well.

	-Arun

--- 1.111/xen/arch/x86/shadow.c 2005-05-12 06:58:45 -07:00
+++ edited/arch/x86/shadow.c    2005-05-13 15:49:11 -07:00
@@ -2336,8 +2336,6 @@
              l1_pgentry_t *shadow1 = shadow;
              l1_pgentry_t *snapshot1 = snapshot;

-            ASSERT(VM_ASSIST(d, VMASST_TYPE_writable_pagetables));
-
              if ( !shadow_mode_refcounts(d) )
                  revalidate_l1(d, guest1, snapshot1);

@@ -2383,7 +2381,6 @@
              l2_pgentry_t *shadow2 = shadow;
              l2_pgentry_t *snapshot2 = snapshot;

-            ASSERT(shadow_mode_write_all(d));
              BUG_ON(!shadow_mode_refcounts(d)); // not yet implemented

              changed = 0;
@@ -2426,7 +2423,6 @@
              l2_pgentry_t *snapshot2 = snapshot;
              l1_pgentry_t *shadow2 = shadow;

-            ASSERT(shadow_mode_write_all(d));
              BUG_ON(!shadow_mode_refcounts(d)); // not yet implemented

              changed = 0;


>