From: Jeff Garzik <jgarzik@pobox.com>
To: domen@coderock.org
Cc: akpm@osdl.org, linux-kernel@vger.kernel.org,
Christophe Lucas <clucas@rotomalug.org>
Subject: Re: [patch 2/3] drivers/char/hw_random.c: replace direct assignment with set_current_state()
Date: Fri, 13 May 2005 20:22:13 -0400 [thread overview]
Message-ID: <428544B5.1080604@pobox.com> (raw)
In-Reply-To: <20050513222409.165372000@nd47.coderock.org>
domen@coderock.org wrote:
> From: Christophe Lucas <clucas@rotomalug.org>
>
>
>
> Use set_current_state() instead of direct assignment of
> current->state.
>
> Signed-off-by: Christophe Lucas <clucas@rotomalug.org>
> Signed-off-by: Domen Puncer <domen@coderock.org>
>
>
> ---
> hw_random.c | 2 +-
> 1 files changed, 1 insertion(+), 1 deletion(-)
>
> Index: quilt/drivers/char/hw_random.c
> ===================================================================
> --- quilt.orig/drivers/char/hw_random.c
> +++ quilt/drivers/char/hw_random.c
> @@ -514,7 +514,7 @@ static ssize_t rng_dev_read (struct file
>
> if(need_resched())
> {
> - current->state = TASK_INTERRUPTIBLE;
> + set_current_state(TASK_INTERRUPTIBLE);
> schedule_timeout(1);
full barriers and such don't seem needed.
Also, make sure to send driver patches to the driver author (me).
Jeff
prev parent reply other threads:[~2005-05-14 0:34 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-05-13 22:24 [patch 2/3] drivers/char/hw_random.c: replace direct assignment with set_current_state() domen
2005-05-14 0:22 ` Jeff Garzik [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=428544B5.1080604@pobox.com \
--to=jgarzik@pobox.com \
--cc=akpm@osdl.org \
--cc=clucas@rotomalug.org \
--cc=domen@coderock.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.