From: Jeff Garzik <jgarzik@pobox.com>
To: Albert Lee <albertcc@tw.ibm.com>
Cc: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>,
Doug Maxey <dwm@maxeymade.com>, Jens Axboe <axboe@suse.de>,
Linux IDE <linux-ide@vger.kernel.org>
Subject: Re: [PATCH 1/2] libata-2.6: Prevent the interrupt handler from completing a command twice
Date: Sun, 15 May 2005 18:47:11 -0400 [thread overview]
Message-ID: <4287D16F.7080602@pobox.com> (raw)
In-Reply-To: <4271FFC3.5070403@tw.ibm.com>
Albert Lee wrote:
> Hi Jeff,
>
> Problem:
> During the libata CD-ROM stress test, sometimes the "BUG: timeout
> without command" error is seen.
>
> Root cause:
> Unexpected interrupt occurs after the ata_qc_complete() is called, but
> before the SCSI error handler.
> The interrupt handler is invoked before the SCSI error handler, and it
> clears the command by calling ata_qc_complete() again.
> Later when the SCSI error handler is run, the ata_queued_cmd is already
> gone, causing the "BUG: timeout without command" error.
>
> Changes:
> - Use the ATA_QCFLAG_ACTIVE flag to prevent the interrupt handler from
> completing the command twice,
> before the scsi_error_handler.
patch applied
next prev parent reply other threads:[~2005-05-15 22:47 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-04-29 9:27 [PATCH 0/2] libata-2.6: Fix races caused by the interrupt handler Albert Lee
2005-04-29 9:34 ` [PATCH 1/2] libata-2.6: Prevent the interrupt handler from completing a command twice Albert Lee
2005-05-15 22:47 ` Jeff Garzik [this message]
2005-04-29 9:39 ` [PATCH 2/2] libata-2.6: Ignore interrupt before the ATAPI CDB is sent to the device Albert Lee
2005-05-15 22:49 ` Jeff Garzik
2005-05-16 10:37 ` Albert Lee
2005-06-08 8:02 ` [PATCH 1/1] libata: Handle ATAPI interrupt before CDB is sent Albert Lee
2005-06-08 10:01 ` Bartlomiej Zolnierkiewicz
2005-06-08 12:17 ` Albert Lee
2005-06-09 7:13 ` Albert Lee
2005-06-28 3:06 ` [PATCH 2/2] libata-2.6: Ignore interrupt before the ATAPI CDB is sent to the device Jeff Garzik
2005-06-28 10:05 ` Albert Lee
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4287D16F.7080602@pobox.com \
--to=jgarzik@pobox.com \
--cc=albertcc@tw.ibm.com \
--cc=axboe@suse.de \
--cc=bzolnier@gmail.com \
--cc=dwm@maxeymade.com \
--cc=linux-ide@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.