From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: Stephen Hemminger <stephen@networkplumber.org>
Cc: dev@dpdk.org
Subject: Re: [PATCH 1/2] scripts: add checkpatch wrapper
Date: Fri, 23 Oct 2015 18:34:23 +0200 [thread overview]
Message-ID: <4288301.N0F7Gaqfh8@xps13> (raw)
In-Reply-To: <20151023090325.3a83fa0c@xeon-e3>
2015-10-23 09:03, Stephen Hemminger:
> Thomas Monjalon <thomas.monjalon@6wind.com> wrote:
> > +options="$options --ignore=LINUX_VERSION_CODE,FILE_PATH_CHANGES,\
> > +VOLATILE,PREFER_PACKED,PREFER_ALIGNED,PREFER_PRINTF,PREFER_KERNEL_TYPES,\
> > +SPLIT_STRING,LINE_SPACING,PARENTHESIS_ALIGNMENT,NETWORKING_BLOCK_COMMENT_STYLE,\
> > +NEW_TYPEDEFS,COMPLEX_MACRO,COMPARISON_TO_NULL"
>
> Please keep some of these:
> PARENTHESIS_ALIGNMENT
It is not written in the DPDK coding rules that
"Alignment should match open parenthesis"
> LINUX_VERSION_CODE
It is used for out-of-tree modules.
> COMPLEX_MACRO
I don't remember why I've ignored this one:
"Macros with complex values should be enclosed in parentheses"
> All of these are indications of problems in code.
I don't think so for the DPDK case, except COMPLEX_MACRO.
Thanks for catching.
next prev parent reply other threads:[~2015-10-23 16:35 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-23 15:53 [PATCH 0/2] more basic tests Thomas Monjalon
2015-10-23 15:53 ` [PATCH 1/2] scripts: add checkpatch wrapper Thomas Monjalon
2015-10-23 16:03 ` Stephen Hemminger
2015-10-23 16:34 ` Thomas Monjalon [this message]
2015-10-23 16:56 ` Stephen Hemminger
2015-10-23 16:58 ` Stephen Hemminger
2015-10-23 20:27 ` Thomas Monjalon
2015-10-29 12:17 ` Bruce Richardson
2015-10-29 12:33 ` David Marchand
2015-10-29 13:03 ` Thomas Monjalon
2015-10-29 13:24 ` Bruce Richardson
2015-10-29 13:34 ` Thomas Monjalon
2015-10-29 13:48 ` Bruce Richardson
2015-10-29 13:54 ` David Marchand
2015-10-29 13:57 ` Thomas Monjalon
2015-10-30 16:16 ` Bruce Richardson
2015-10-30 16:23 ` Thomas Monjalon
2015-11-02 10:28 ` Van Haaren, Harry
2015-11-02 10:33 ` Bruce Richardson
2015-10-23 15:53 ` [PATCH 2/2] scripts: add build tests Thomas Monjalon
2015-11-23 1:40 ` [PATCH v2 0/2] more basic tests Thomas Monjalon
2015-11-23 1:40 ` [PATCH v2 1/2] scripts: add checkpatch wrapper Thomas Monjalon
2015-11-24 16:33 ` Bruce Richardson
2015-11-23 1:40 ` [PATCH v2 2/2] scripts: add build tests Thomas Monjalon
2015-11-24 17:49 ` Mcnamara, John
2015-11-24 18:14 ` Thomas Monjalon
2015-12-03 17:39 ` [PATCH v2 0/2] more basic tests Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4288301.N0F7Gaqfh8@xps13 \
--to=thomas.monjalon@6wind.com \
--cc=dev@dpdk.org \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.