From: Thomas Monjalon <thomas.monjalon-pdR9zngts4EAvxtiuMwx3w@public.gmane.org>
To: Aaron Campbell <aaron-rd7evPjynkNeoWH0uzbU5w@public.gmane.org>
Cc: dev-VfR2kkLFssw@public.gmane.org
Subject: Re: [PATCH] eal: fix invalid memory read as reported by valgrind
Date: Fri, 27 Jun 2014 02:56:48 +0200 [thread overview]
Message-ID: <4288998.3pALjXkCDh@xps13> (raw)
In-Reply-To: <1403794474-17695-1-git-send-email-aaron-rd7evPjynkNeoWH0uzbU5w@public.gmane.org>
2014-06-26 10:54, Aaron Campbell:
> ==29880== Invalid read of size 1
> ==29880== at 0x56FF9A5: cpu_socket_id (eal_lcore.c:101)
> ==29880== by 0x56FFAE9: rte_eal_cpu_init (eal_lcore.c:168)
> ==29880== by 0x56F944A: rte_eal_init (eal.c:975)
>
> The problem is that endptr points to memory allocated underneath the DIR
> handle, which has already been freed. So move the closedir() call lower.
>
> Signed-off-by: Aaron Campbell <aaron-rd7evPjynkNeoWH0uzbU5w@public.gmane.org>
Good catch!
Acked-by: Thomas Monjalon <thomas.monjalon-pdR9zngts4EAvxtiuMwx3w@public.gmane.org>
Applied for version 1.7.0.
Thanks
--
Thomas
prev parent reply other threads:[~2014-06-27 0:56 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-26 14:54 [PATCH] eal: fix invalid memory read as reported by valgrind Aaron Campbell
[not found] ` <1403794474-17695-1-git-send-email-aaron-rd7evPjynkNeoWH0uzbU5w@public.gmane.org>
2014-06-27 0:56 ` Thomas Monjalon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4288998.3pALjXkCDh@xps13 \
--to=thomas.monjalon-pdr9zngts4eavxtiumwx3w@public.gmane.org \
--cc=aaron-rd7evPjynkNeoWH0uzbU5w@public.gmane.org \
--cc=dev-VfR2kkLFssw@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.