All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jeff Garzik <jgarzik@pobox.com>
To: Herbert Xu <herbert@gondor.apana.org.au>
Cc: Ganesh Venkatesan <ganesh.venkatesan@gmail.com>,
	Andrew Morton <akpm@osdl.org>,
	netdev@oss.sgi.com, hejianj@cn.ibm.com,
	linuxppc64-dev@lists.linuxppc.org.sgi.com, anton@samba.org
Subject: Re: Fw: [Bugme-new] [Bug 4628] New: Test server hang while running rhr (network) test on RHEL4 with kernel 2.6.12-rc1-mm4
Date: Mon, 16 May 2005 17:58:52 -0400	[thread overview]
Message-ID: <4289179C.6090900@pobox.com> (raw)
In-Reply-To: <20050516212957.GA19211@gondor.apana.org.au>

Herbert Xu wrote:
> On Mon, May 16, 2005 at 10:43:02AM -0700, Ganesh Venkatesan wrote:
> 
>>@@ -1708,11 +1778,15 @@ err_rx_clean_list:
>>
>> static void e100_down(struct nic *nic)
>> {
>>+#ifdef CONFIG_E100_NAPI
>>+       /* wait here for poll to complete */
>>+       netif_poll_disable(nic->netdev);
>>+#endif
> 
> 
> Sorry, you can't do that here since you're in softirq context and
> netif_poll_disable may sleep.

I think the intention is that e100_down() may sleep, from looking at all 
the callsites.

Only e100_tx_timeout() calls it in a context that prevents sleep.

	Jeff

  reply	other threads:[~2005-05-16 21:58 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-05-16  9:59 Fw: [Bugme-new] [Bug 4628] New: Test server hang while running rhr (network) test on RHEL4 with kernel 2.6.12-rc1-mm4 Andrew Morton
2005-05-16 10:41 ` Jian Jun He
2005-05-16 11:00 ` Herbert Xu
2005-05-16 17:43   ` Ganesh Venkatesan
2005-05-16 21:29     ` Herbert Xu
2005-05-16 21:58       ` Jeff Garzik [this message]
     [not found]     ` <OFB1F7DBFD.6A6514AD-ON48257004.0038A154-48257004.0038E08A@cn.ibm.com>
2005-05-26  7:38       ` Andrew Morton
2005-05-26  7:53         ` Jeff Garzik
2005-05-24 18:36 ` Ganesh Venkatesan
2005-05-25  3:21   ` Jian Jun He
  -- strict thread matches above, loose matches on Subject: below --
2005-05-26 13:00 Venkatesan, Ganesh
2005-05-26 16:09 ` Jian Jun He
2005-05-26 20:31   ` Andrew Morton
2005-05-27  6:18     ` Jian Jun He
2005-05-27  8:21       ` Andrew Morton
2005-05-27 10:12         ` Jian Jun He
2005-05-26 20:41 Venkatesan, Ganesh
2005-05-26 21:34 ` Herbert Xu
2005-05-26 23:08   ` Ganesh Venkatesan
2005-05-27  0:11     ` Herbert Xu
2005-05-27  0:20       ` Herbert Xu
2005-05-27  0:28 Venkatesan, Ganesh
2005-05-27  1:26 ` Herbert Xu
2005-05-27  1:44   ` Andrew Morton

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4289179C.6090900@pobox.com \
    --to=jgarzik@pobox.com \
    --cc=akpm@osdl.org \
    --cc=anton@samba.org \
    --cc=ganesh.venkatesan@gmail.com \
    --cc=hejianj@cn.ibm.com \
    --cc=herbert@gondor.apana.org.au \
    --cc=linuxppc64-dev@lists.linuxppc.org.sgi.com \
    --cc=netdev@oss.sgi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.