All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Eric A. Cottrell" <eac@shore.net>
To: Jeff Garzik <jgarzik@pobox.com>
Cc: Linux IDE <linux-ide@vger.kernel.org>
Subject: Re: [PATCH 2.6.12-rc2 2/2] libata: add basic atapi error reporting
Date: Mon, 16 May 2005 23:02:31 -0400	[thread overview]
Message-ID: <42895EC7.4060706@shore.net> (raw)
In-Reply-To: <428808B4.8040102@pobox.com>

Jeff Garzik wrote:
> Eric A. Cottrell wrote:
>> Hello Jeff,
>>
>> Problem:
>> ATAPI errors are not fully reported to the SCSI subsystem.  A check 
>> condition was returned but the SCSI subsystem does not get the sense 
>> from the device.  This causes problems when unimplemented and bad SCSI 
>> commands are sent to an atapi device.
> 
> This is a bit strange.  It should get the sense from the device.  It is 
> requested from ata_qc_timeout().  Is this not happening for you?
> 
>     Jeff
> 
> 
> 
Hello,

It does not seem to work in all cases.  I had the most trouble with the 
AHCI driver.  I wish to withdraw part 2 of the patch because I realize 
that this is only an incomplete solution.  Full sense information needs 
to be sent to the SCSI subsystem for it to work properly.  I was able to 
modify the driver to Autosense on ATAPI errors and improved it.  It is 
not complete yet.

I am still having problems.  I can burn a CD but not a DVD.  On a 
working drive there is a long delay as the DVD lead-in is written then 
the written data amount will increase.  With libata it appears that 
something is timing out way too quickly (within a second) and the 
burning program stops with an error.

I need to setup git and grab the libata-dev stuff before I continue.

73 Eric

      parent reply	other threads:[~2005-05-17  3:02 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-04-17  1:55 [PATCH 2.6.12-rc2 2/2] libata: add basic atapi error reporting Eric A. Cottrell
2005-05-16  2:43 ` Jeff Garzik
2005-05-16 13:24   ` Mark Lord
2005-05-17  3:02   ` Eric A. Cottrell [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=42895EC7.4060706@shore.net \
    --to=eac@shore.net \
    --cc=jgarzik@pobox.com \
    --cc=linux-ide@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.