From: Patrick McHardy <kaber@trash.net>
To: Max Kellermann <max@duempel.org>
Cc: netfilter-devel@lists.netfilter.org, laforge@gnumonks.org
Subject: Re: [PATCH pom-ng 4/6] H.323: splitted ip_conntrack_h323.c into 3 sources
Date: Tue, 17 May 2005 17:39:38 +0200 [thread overview]
Message-ID: <428A103A.2040205@trash.net> (raw)
In-Reply-To: <20050512052604.GA18421@roonstrasse.net>
Max Kellermann wrote:
> On 2005/05/12 01:40, Patrick McHardy <kaber@trash.net> wrote:
>
>>This file looks a bit unnecessary, I suggest to put register/unregister
>>in ip_conntrack_h323_h225.c.
>
> I splitted the file because it became very large (I dislike sources >
> 500 lines). I decided to make a _core.c because this way, the _h225.c
> and _h245.c contain only protocol parser code, and nothing else -
> still having the option to add more "common" code to _core.c (whatever
> happens in further development).
>
> In the compiled binary, there is no advantage of merging _core and
> _h225.c.
>
> A matter of personal taste. If you vote me down on this one, I'll
> change it.
Well, lets keep it this way for now and wait if something else is added.
If we decide to merge it some day we can still change it.
Regards
Patrick
next prev parent reply other threads:[~2005-05-17 15:39 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-05-10 22:50 [PATCH pom-ng 0/6] H.323: implement a "real" H.245 parser Max Kellermann
2005-05-10 22:51 ` [PATCH pom-ng 1/6] H.323: remove struct ip_ct_h225_master Max Kellermann
2005-05-10 22:51 ` [PATCH pom-ng 2/6] add ip_nat_h245() Max Kellermann
2005-05-10 22:52 ` [PATCH pom-ng 3/6] H.323: minor code style fixes Max Kellermann
2005-05-10 22:52 ` [PATCH pom-ng 4/6] H.323: splitted ip_conntrack_h323.c into 3 sources Max Kellermann
2005-05-11 23:40 ` Patrick McHardy
2005-05-12 5:26 ` Max Kellermann
2005-05-17 15:39 ` Patrick McHardy [this message]
2005-05-10 22:53 ` [PATCH pom-ng 5/6] H.323: ASN.1/PER parser Max Kellermann
2005-05-10 22:54 ` [PATCH pom-ng 6/6] H.323: H.245/ASN.1 parser Max Kellermann
2005-05-11 8:01 ` [PATCH pom-ng 0/6] H.323: implement a "real" H.245 parser Harald Welte
2005-05-11 18:16 ` [PATCH pom-ng 7/6] H.323: reimplement the H.225 parser using the ASN.1/PER library Max Kellermann
2005-05-17 15:18 ` Patrick McHardy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=428A103A.2040205@trash.net \
--to=kaber@trash.net \
--cc=laforge@gnumonks.org \
--cc=max@duempel.org \
--cc=netfilter-devel@lists.netfilter.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.