From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ybbsmtp10.mail.mci.yahoo.co.jp (ybbsmtp10.mail.mci.yahoo.co.jp [210.80.241.184]) by ozlabs.org (Postfix) with SMTP id 5FD2867A06 for ; Wed, 18 May 2005 03:36:15 +1000 (EST) Message-ID: <428A2CCD.5070704@ybb.ne.jp> Date: Wed, 18 May 2005 02:41:33 +0900 From: Takeharu KATO MIME-Version: 1.0 To: Kumar Gala References: <428A040D.40604@ybb.ne.jp> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Cc: Glenn Burkhardt , "Gala Kumar K.-galak" , linuxppc-embedded@ozlabs.org Subject: Re: [PATCH] BOOKE_WDT Part 1/2 (Re: PPC 44x Watchdog timer) List-Id: Linux on Embedded PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Hi Kumar: > > Yes, I think with these changes to us early_param() for command line > parsing in a single place will make the first patch look good. > OK, I'll perform this fix in this week. > I'm still not sure what suggestions I have for the second patch, I was > more just letting you know my thinking about the fact that it concerned > me that the exception handler code was not in arch/ppc/kernel. Not to > say this is wrong, it just doesn't feel write. > Hum, I agree this thing, I'll move the WDT exception handler to arch/ppc/kernel for the moment. If someone disagree with this decision in the future, I'll move this into driver code again.