Re: [PATCH] replace tabs with spaces of Python code

[Anthony Liguori <aliguori@us.ibm.com>]

[-- Attachment #1: Type: text/plain, Size: 2800 bytes --]

Ian Pratt wrote:

> 
>
>  
>
>>there are many Python codes in tools/ that mix tab and space 
>>for indentation, which might introduce some silly and hidden 
>>bugs. this is a serious problem and must be avoid at all cost.
>>
>>here is a patch (against cset 1.1452) to replace all tabs with spaces.
>>all the changes are pretty trivial, and i double checked everything.
>>please take a look to see if all the modifies are OK.
>>
>>Signed-off-by: Nguyen Anh Quynh <aquynh@gmail.com>
>>    
>>
>
>Are you sure python interprets a tab as a 4 spaces? I thought it
>interpretted it as 8?
>  
>
It's not that simple.  Check out 2.1.8 of the python language spec.

http://docs.python.org/ref/indentation.html

Tabs are expanded to the next 8 character column.  The following script 
expands tabs as described in the python standard.  I don't know how to 
do tab expansion in sed.

Regards,

Anthony Liguori

Signed-off-by: Anthony Liguori

>Hmm, there are a whole bunch of outstanding xend patches this this is
>going to create merge hell for, so I'm not sure we want to apply this
>straight away.
>
>Could you just post the script you used, or did you just do the obvious
>sed invocation?
>
>Thanks,
>Ian
>
>  
>
>>any idea? if nobody complains, i would prepare a patch like 
>>this for -testing tree.
>>
>>
>>$ diffstat removetab.patch 
>> logging/logging-0.4.9.2/test/mymodule.py |    6 +-
>> xen/sv/CreateDomain.py                   |   34 ++++++++--------
>> xen/sv/Daemon.py                         |    2 
>> xen/sv/DomInfo.py                        |   55 
>>++++++++++++--------------
>> xen/sv/DomList.py                        |   16 +++----
>> xen/sv/GenTabbed.py                      |    6 +-
>> xen/sv/HTMLBase.py                       |    4 -
>> xen/sv/Main.py                           |   12 ++---
>> xen/sv/NodeInfo.py                       |   16 +++----
>> xen/sv/Wizard.py                         |   64 
>>+++++++++++++++----------------
>> xen/sv/util.py                           |    6 +-
>> xen/web/SrvBase.py                       |    6 +-
>> xen/web/SrvDir.py                        |    2 
>> xen/xend/EventServer.py                  |   24 +++++------
>> xen/xend/PrettyPrint.py                  |    6 +-
>> xen/xend/XendClient.py                   |    6 +-
>> xen/xend/XendDomain.py                   |    4 -
>> xen/xend/encode.py                       |    2 
>> xen/xend/server/SrvDomain.py             |    6 +-
>> xen/xend/sxp.py                          |    2 
>> xen/xm/main.py                           |   12 ++---
>> 21 files changed, 143 insertions(+), 148 deletions(-)
>>
>>--
>>regards,
>>aq
>>
>>    
>>
>
>_______________________________________________
>Xen-devel mailing list
>Xen-devel@lists.xensource.com
>http://lists.xensource.com/xen-devel
>
>  
>


[-- Attachment #2: tab2space.py --]
[-- Type: application/x-python, Size: 507 bytes --]

[-- Attachment #3: Type: text/plain, Size: 138 bytes --]

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel