From mboxrd@z Thu Jan  1 00:00:00 1970
From: David Hopwood <david.nospam.hopwood@blueyonder.co.uk>
Subject: Re: [PATCH] add need definitions to libxc for x86-64
Date: Wed, 18 May 2005 21:50:04 +0100
Message-ID: <428BAA7C.5050706@blueyonder.co.uk>
References: <1116349175.7641.3.camel@thinkpad>
Reply-To: david.nospam.hopwood@blueyonder.co.uk
Mime-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xensource.com>
In-Reply-To: <1116349175.7641.3.camel@thinkpad>
List-Unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xensource.com>
List-Help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-Subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
Sender: xen-devel-bounces@lists.xensource.com
Errors-To: xen-devel-bounces@lists.xensource.com
To: xen-devel@lists.xensource.com
List-Id: xen-devel@lists.xenproject.org

Jerone Young wrote:
> This patch adds need definitions to xc_private.h so that libxc can be
> x86-64 enabled.

> +#if defined(__i386__) 
>  #define ENTRIES_PER_L1_PAGETABLE 1024
>  #define ENTRIES_PER_L2_PAGETABLE 1024
> +#elif defined(__x86_64__)
> +#define L1_PAGETABLE_ENTRIES    512
> +#define L2_PAGETABLE_ENTRIES    512
> +#define L3_PAGETABLE_ENTRIES    512
> +#define L4_PAGETABLE_ENTRIES    512
> +#endif

Why aren't these named consistently (all "ENTRIES_PER_Lx_PAGETABLE" or
all "Lx_PAGETABLE_ENTRIES")?

-- 
David Hopwood <david.nospam.hopwood@blueyonder.co.uk>