All of lore.kernel.org
 help / color / mirror / Atom feed
From: Chris Friesen <cfriesen@nortel.com>
To: Coywolf Qi Hunt <coywolf@lovecn.org>
Cc: akpm@osdl.org, linux-kernel@vger.kernel.org
Subject: Re: [patch] time_after_eq fix
Date: Wed, 18 May 2005 17:14:43 -0600	[thread overview]
Message-ID: <428BCC63.4070101@nortel.com> (raw)
In-Reply-To: <20050518224415.GA5768@lovecn.org>

Coywolf Qi Hunt wrote:
> Hello,
> 
> The two macros time_after and time_after_eq were added to do wrapping
> correctly, but only time_after does it the right way, time_after_eq has
> been wrong since the very beginning(v2.1.127, 07-Nov-1998).

> -	 ((long)(a) - (long)(b) >= 0))
> +	 ((long)(b) - (long)(a) <= 0))

Why does it matter which way you do it?  In what circumstances does your 
code give a different answer?


Chris

  reply	other threads:[~2005-05-18 23:15 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-05-18 22:44 [patch] time_after_eq fix Coywolf Qi Hunt
2005-05-18 23:14 ` Chris Friesen [this message]
2005-05-18 23:36 ` Linus Torvalds
2005-05-19  1:03 ` George Anzinger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=428BCC63.4070101@nortel.com \
    --to=cfriesen@nortel.com \
    --cc=akpm@osdl.org \
    --cc=coywolf@lovecn.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.